-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor sample generator in mgmt #5107
Merged
ArcturusZhang
merged 61 commits into
Azure:main
from
ArcturusZhang:refactor-mgmt-sample-generator
Nov 26, 2024
Merged
Refactor sample generator in mgmt #5107
ArcturusZhang
merged 61 commits into
Azure:main
from
ArcturusZhang:refactor-mgmt-sample-generator
Nov 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArcturusZhang
requested review from
m-nash,
lirenhe,
ArthurMa1978,
hallipr and
JoshLove-msft
as code owners
November 12, 2024 05:46
This comment was marked as outdated.
This comment was marked as outdated.
ArcturusZhang
commented
Nov 21, 2024
src/AutoRest.CSharp/Common/Output/Expressions/Samples/Snippets.ExampleValues.cs
Show resolved
Hide resolved
live1206
reviewed
Nov 21, 2024
src/AutoRest.CSharp/Common/Output/Expressions/Samples/Snippets.ExampleValues.cs
Show resolved
Hide resolved
src/AutoRest.CSharp/Common/Output/Models/Samples/ExampleParameterValue.cs
Show resolved
Hide resolved
live1206
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5079
Description
A thorough refactor on how the samples are written in mgmt plane.
MgmtTestConfiguration
remains. We will refactor those parts in later PRs, including introducing similar configurations to typespec inputAbout changes in regen PR:
We do have quite a lot of changes in the regen PR, because now to generate the content of the sample, we are reusing the code written for DPG's sample a few months ago, which introduces quite a few style changes, such as, previously we might have:
now we might have:
Also because of now sample generation is not in a standalone target, we have quite a few order changes in those generated methods.
To summary, the majority of those massive changes in the regen PR come from the style change, or ordering change.
Checklist
To ensure a quick review and merge, please ensure:
Ready to Land?