Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dpg): duplicated result retrieval methods when polling operation is referenced multiple times #5116

Merged
merged 2 commits into from
Oct 17, 2024
Merged

fix(dpg): duplicated result retrieval methods when polling operation is referenced multiple times #5116

merged 2 commits into from
Oct 17, 2024

Conversation

archerzz
Copy link
Member

Description

  • when writing result retrieval methods, avoid duplicated instances
  • add test case which should be added into cadl-ranch later

fix #5113

Checklist

To ensure a quick review and merge, please ensure:

  • The PR has a understandable title and description explaining the why and what.
  • The PR is opened in draft if not ready for review yet.
    • If opened in draft, please allocate sufficient time (24 hours) after moving out of draft for review
  • The branch is recent enough to not have merge conflicts upon creation.

Ready to Land?

  • Build is completely green
    • Submissions with test failures require tracking issue and approval of a CODEOWNER
  • At least one +1 review by a CODEOWNER
  • All -1 reviews are confirmed resolved by the reviewer
    • Override/Marking reviews stale must be discussed with CODEOWNERS first

@archerzz
fix(dpg): duplicated result retrieval methods when polling operation …
3187342 
…is referenced multiple times

- when writing result retrieval methods, avoid duplicated instances
- add test case which should be added into cadl-ranch later

fix Azure#5113
@archerzz archerzz added the DPG label Oct 16, 2024
@azure-sdk azure-sdk mentioned this pull request Oct 16, 2024
Closed
@archerzz archerzz merged commit ad47bb7 into Azure:main Oct 17, 2024
8 checks passed
@archerzz archerzz deleted the fix/dpg/duplicated-result-retrieval-methods branch October 17, 2024 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chunyu3 chunyu3 chunyu3 approved these changes

@m-nash m-nash Awaiting requested review from m-nash m-nash is a code owner

@lirenhe lirenhe Awaiting requested review from lirenhe lirenhe is a code owner

@ArthurMa1978 ArthurMa1978 Awaiting requested review from ArthurMa1978 ArthurMa1978 is a code owner

@hallipr hallipr Awaiting requested review from hallipr hallipr is a code owner

@JoshLove-msft JoshLove-msft Awaiting requested review from JoshLove-msft JoshLove-msft is a code owner

Assignees
No one assigned
Labels
DPG
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[defect] generate duplicate Long Running Result Retrieval Method FetchXXXFromXXX methods
2 participants
@archerzz @chunyu3