Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support enums in queries, urls and headers #536

Merged
merged 4 commits into from
Mar 16, 2020

Conversation

pakrym
Copy link
Contributor

@pakrym pakrym commented Mar 13, 2020

Fixes: #325
Fixes: #486

@pakrym pakrym requested a review from MiYanni March 13, 2020 21:49
@@ -172,7 +174,8 @@ private void WriteRequestCreation(CodeWriter writer, RestClientMethod operation)

private void WriteUriFragment(CodeWriter writer, PathSegment segment)
{
writer.Append($"uri.AppendRaw({WriteConstantOrParameter(segment.Value)}");
writer.Append($"uri.AppendRaw(");
WriteConstantOrParameter(writer, segment.Value);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failed experiment...

@pakrym
Copy link
Contributor Author

pakrym commented Mar 13, 2020

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@pakrym pakrym merged commit 1423628 into Azure:feature/v3 Mar 16, 2020
@pakrym pakrym deleted the pakrym/enums-query-url branch March 16, 2020 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants