x-ms-discriminator-value #13
Conversation
|
@mcardosos, |
|
@mcardosos I cancelled |
|
@mcardosos great, and commenting makes the job think a new commit was done, so now Linux reruns... feel free to merge X'D |
src/Templates/EnumTemplate.cshtml
Outdated
| @@ -13,10 +13,13 @@ | |||
| type @Model.Name string | |||
|
|
|||
| @EmptyLine | |||
| const ( | |||
| @if (constants.Count() > 0) | |||
There was a problem hiding this comment.
Changing this to constants.Any() will reduce this line from O(n) to O(1)
src/Extensions.cs
Outdated
| @@ -113,6 +113,11 @@ public static string[] ToWords(this string value) | |||
| return WordSplitPattern.Split(value).Where(s => !string.IsNullOrEmpty(s)).ToArray(); | |||
| } | |||
|
|
|||
| public static string ToIdiomaticShortName(this string value) | |||
| { | |||
| return CodeNamerGo.Instance.GetVariableName(string.Concat(value.ToPhrase().Split(new char[]{' '}).Select(w => w[0]))); | |||
There was a problem hiding this comment.
I think this could be rewritten to be a little bit easier to read. Maybe,
public static string ToIdiomaticShortName(this string longName)
{
var initials = from word in longName.ToPhrase().Split(new []{' '})
select word[0];
var acronym = string.Concat(initials);
return CodeNamerGo.Instance.GetVariableName(acronym);
}
There was a problem hiding this comment.
To throw another option into the mix, I wrote the follow function for creating vars from pascal-cased strings.
public static string ToShortVarName(this string name)
{
var sb = new StringBuilder();
for (int i = 0; i < name.Length; ++i)
{
if (char.IsUpper(name[i]))
{
sb.Append(char.ToLowerInvariant(name[i]));
}
}
return sb.ToString();
}
src/Model/CompositeTypeGo.cs
Outdated
| } | ||
| } | ||
|
|
||
| public bool HasPolymorphicFields => AllProperties.Any(p => (p.ModelType is CompositeType && (p.ModelType as CompositeTypeGo).IsPolymorphic) |
There was a problem hiding this comment.
Too much shortening! Lets give this a real method body.
There was a problem hiding this comment.
Made all this more readable
src/Model/CompositeTypeGo.cs
Outdated
| { | ||
| if (!string.IsNullOrEmpty(PolymorphicDiscriminator) && Properties.All(p => p.SerializedName != PolymorphicDiscriminator)) | ||
| { | ||
| var newProp = base.Add(New<Property>(new |
There was a problem hiding this comment.
Why are we saving the result of base.Add? It doesn't look like it gets used.
src/Extensions.cs
Outdated
| @@ -113,6 +113,11 @@ public static string[] ToWords(this string value) | |||
| return WordSplitPattern.Split(value).Where(s => !string.IsNullOrEmpty(s)).ToArray(); | |||
| } | |||
|
|
|||
| public static string ToIdiomaticShortName(this string value) | |||
There was a problem hiding this comment.
Shouldn't all names be Idiomatic? Maybe a more appropriate name would be ToShortName
| @@ -355,8 +360,23 @@ public static void AddImports(this IModelType type, HashSet<string> imports) | |||
| } | |||
|
|
|||
| public static bool ShouldBeSyntheticType(this IModelType type) | |||
| { | |||
| return (type is PrimaryType || type is SequenceType || type is DictionaryType || type is EnumType || | |||
| (type is CompositeTypeGo && (type as CompositeTypeGo).IsPolymorphicResponse())); | |||
There was a problem hiding this comment.
Why do we need to generate a synthetic type for polymorphic responses?
There was a problem hiding this comment.
Because they need a wrapper to be unmarshalled
* works for storage blob serivce now * add TODO and some comments * use === instead of == * use ternary operation * use interface * f * javascript prettier * Add todo
Closing #4 and opening this
PTAL @jhendrixMSFT @marstr