Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go report TCGC diagnostics #1500

Merged
merged 4 commits into from
Feb 21, 2025
Merged

go report TCGC diagnostics #1500

merged 4 commits into from
Feb 21, 2025

Conversation

JiaqiZhang-Dev
Copy link
Member

resolve: #1485

@JiaqiZhang-Dev
Copy link
Member Author

@chlowell This pr is for reporting tcgc diagnostics. When i run the typespec-go test, there is an error caused by packages\typespec-go\test\tsp\Internal.Pager\main.tsp, it seems that pageResult model is not valid. I fixed the tsp file so that it could be pass the test, could you please check the file change is ok?
image

@jhendrixMSFT jhendrixMSFT force-pushed the go_report_diagnostics branch 2 times, most recently from b67f6bd to d891af5 Compare February 21, 2025 16:06
@chlowell
Copy link
Member

@chlowell This pr is for reporting tcgc diagnostics. When i run the typespec-go test, there is an error caused by packages\typespec-go\test\tsp\Internal.Pager\main.tsp, it seems that pageResult model is not valid. I fixed the tsp file so that it could be pass the test, could you please check the file change is ok?

It's ok, your change doesn't affect the test. Thanks for fixing the TSP

@jhendrixMSFT jhendrixMSFT merged commit f797b20 into main Feb 21, 2025
8 checks passed
@jhendrixMSFT jhendrixMSFT deleted the go_report_diagnostics branch February 21, 2025 22:42
@jhendrixMSFT
Copy link
Member

@tadelesh there are a lot of warning diagnostics from tcgc that we're now seeing with this change. They come from @azure-tools/typespec-azure-resource-manager, @azure-tools/typespec-client-generator-core and @azure-tools/typespec-azure-core. Are these known issues?

See the log for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tadelesh tadelesh tadelesh approved these changes

@jhendrixMSFT jhendrixMSFT jhendrixMSFT approved these changes

@chlowell chlowell Awaiting requested review from chlowell chlowell is a code owner

@RickWinter RickWinter Awaiting requested review from RickWinter RickWinter is a code owner

@ArcturusZhang ArcturusZhang Awaiting requested review from ArcturusZhang

@lirenhe lirenhe Awaiting requested review from lirenhe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Go CodeGen should address the errors and warnings from TCGC
4 participants
@JiaqiZhang-Dev @chlowell @jhendrixMSFT @tadelesh