Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fabric Bot Configuration #1366

Merged
merged 1 commit into from
Feb 24, 2022
Merged

Fabric Bot Configuration #1366

merged 1 commit into from
Feb 24, 2022

Conversation

jsquire
Copy link
Member

@jsquire jsquire commented Feb 18, 2022

The focus of these changes is to add the Fabric Bot rules into the repository.

The focus of these changes is to add the Fabric Bot rules into the repository.
@weidongxu-microsoft
Copy link
Member

@jsquire
Would you let us know what the bot for? Any other repo having the bot and may I see their action?

@jsquire
Copy link
Member Author

jsquire commented Feb 22, 2022

@weidongxu-microsoft: This is an export of the [Fabric Bot] rules that exist today for this repository. No rule changes have been made, the bot portal is being retired and we'll need to shift to this configuration-based approach to have automation continue to take place.

@danieljurek
Copy link
Member

This PR is stuck in validation for reasons unrelated to the current change -- https://dev.azure.com/azure-sdk/internal/_build/results?buildId=1378259&view=logs&j=ca395085-040a-526b-2ce8-bdc85f692774&t=cb33ee24-f492-54d2-727a-ae0a7bb84b2c

How can we get this merged?

@weidongxu-microsoft
Copy link
Member

weidongxu-microsoft commented Feb 23, 2022

@danieljurek
No need to worry about CI. It is indeed not related, and fixed in latest main. I need to double check with Srikanta before the merge (together with #1367).

BTW "You don't have permission to view bot tasks.". I would appreciate a quick doc on what FabricBot does to the repo.

@srnagar Let me know if you are OK with it.
I see the same PR on azure-sdk-for-java is already merged Azure/azure-sdk-for-java#27204

@danieljurek
Copy link
Member

@weidongxu-microsoft -- Fabric bot documentation: https://eng.ms/docs/initiatives/open-source-at-microsoft/tools/fabricbot

The rules that are in this PR are already being used on the repository by Fabric Bot and stored in a configuration in the Fabric Bot service. However, the Fabric Bot service is changing to require that the configuration be stored in the repository and this PR is to migrate storage of the Fabric Bot configuration from the Fabric Bot service to this repository.

@srnagar
Copy link
Member

srnagar commented Feb 24, 2022

The build failure is due to a mismatch in javadocs of the generated files caused by this PR which updated the swagger files to add more detailed doc comments. Merging this PR as the build failure is unrelated to this change.

@srnagar srnagar merged commit 373e34c into main Feb 24, 2022
@jsquire jsquire deleted the jsquire-patch-1 branch February 24, 2022 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants