Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Add x-ms-enum's default to SwaggerObject." #11

Merged
merged 2 commits into from
Sep 22, 2017

Conversation

olydis
Copy link
Contributor

@olydis olydis commented Sep 22, 2017

Reverts #9

@amarzavery as far as we can see, this breaks every single generator (NRE's in C#, huge diff in Java, weird change in ARS, ...). We can look at this again after the release.

E.g. take a look at http://autorestci1.blob.core.windows.net/autorest-ci/CImdygk_autorest.nodejs_9_20170922T213752

@msftclas
Copy link

@olydis,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

@fearthecowboy fearthecowboy merged commit cb049d4 into master Sep 22, 2017
@olydis
Copy link
Contributor Author

olydis commented Sep 22, 2017

publish job

failed

npm WARN deprecated minimatch@2.0.10: Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue
npm WARN deprecated minimatch@0.2.14: Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue
npm WARN deprecated graceful-fs@1.2.3: graceful-fs v3.0.0 and before will fail on node releases >= v7.0. Please update to graceful-fs@^4.0.0 as soon as possible. Use 'npm ls graceful-fs' to find it in the tree.

> dotnet-2.0.0@1.2.0 postinstall C:\Users\ci\AppData\Local\Temp\PUBLISHugt8j\11_20170922T214144\autorest.modeler\node_modules\dotnet-2.0.0
> node -e "try { fs.statSync('./dist/app.js') ; require('./dist/app.js')} catch (e){}"

Recording package path for platform-specific runtime: C:\Users\ci\.net\2.0.0\node_modules\dotnet-2.0.0-win\

> dotnet-sdk-2.0.0@1.2.0 postinstall C:\Users\ci\AppData\Local\Temp\PUBLISHugt8j\11_20170922T214144\autorest.modeler\node_modules\dotnet-sdk-2.0.0
> node -e "try { fs.statSync('./dist/app.js') ; require('./dist/app.js')} catch (e){}"

Recording package path for platform-specific runtime: C:\Users\ci\.net\2.0.0\node_modules\dotnet-sdk-2.0.0-win\

> @microsoft.azure/autorest.modeler@2.0.0 prepare C:\Users\ci\AppData\Local\Temp\PUBLISHugt8j\11_20170922T214144\autorest.modeler
> gulp build

[14:42:50] Using gulpfile ~\AppData\Local\Temp\PUBLISHugt8j\11_20170922T214144\autorest.modeler\gulpfile.js
[14:42:50] Starting 'init'...
[14:42:50] Finished 'init' after 717 μs
[14:42:50] Starting 'clear-cache-on-force'...
[14:42:50] Finished 'clear-cache-on-force' after 34 μs
[14:42:50] Starting 'restore'...
[14:42:50] Starting 'version-number'...
           C:\Users\ci\AppData\Local\Temp\PUBLISHugt8j\11_20170922T214144\autorest.modeler :: dotnet restore C:\Users\ci\AppData\Local\Temp\PUBLISHugt8j\11_20170922T214144\autorest.modeler\src\autorest.modeler.csproj /nologo
[14:42:51] Finished 'version-number' after 864 ms
           C:\Users\ci\AppData\Local\Temp\PUBLISHugt8j\11_20170922T214144\autorest.modeler :: dotnet restore C:\Users\ci\AppData\Local\Temp\PUBLISHugt8j\11_20170922T214144\autorest.modeler\test\autorest.modeler.test.csproj /nologo
[14:42:59] Finished 'restore' after 9.77 s
[14:42:59] Starting 'build/dotnet'...
           C:\Users\ci\AppData\Local\Temp\PUBLISHugt8j\11_20170922T214144\autorest.modeler :: dotnet build -c Debug C:\Users\ci\AppData\Local\Temp\PUBLISHugt8j\11_20170922T214144\autorest.modeler/autorest.modeler.sln /nologo /clp:NoSummary /p:VersionPrefix=2.0.14
           C:\Users\ci\AppData\Local\Temp\PUBLISHugt8j\11_20170922T214144\autorest.modeler :: dotnet publish -c Debug C:\Users\ci\AppData\Local\Temp\PUBLISHugt8j\11_20170922T214144\autorest.modeler/src/ --output C:\Users\ci\AppData\Local\Temp\PUBLISHugt8j\11_20170922T214144\autorest.modeler/src//bin/netcoreapp2.0 /nologo /clp:NoSummary /p:VersionPrefix=2.0.14
[14:43:44] Finished 'build/dotnet' after 45 s
[14:43:44] Starting 'build'...
Building project in C:\Users\ci\AppData\Local\Temp\PUBLISHugt8j\11_20170922T214144\autorest.modeler
[14:43:44] Finished 'build' after 208 μs
npm notice created a lockfile as package-lock.json. You should commit this file.
added 287 packages in 114.935s

> @microsoft.azure/autorest.modeler@2.0.0 publish-preview C:\Users\ci\AppData\Local\Temp\PUBLISHugt8j\11_20170922T214144\autorest.modeler
> gulp publish-preview

[14:43:50] Using gulpfile ~\AppData\Local\Temp\PUBLISHugt8j\11_20170922T214144\autorest.modeler\gulpfile.js
[14:43:50] Starting 'init'...
[14:43:50] Finished 'init' after 3.6 ms
[14:43:50] Starting 'version-number'...
[14:43:50] Finished 'version-number' after 170 ms
[14:43:50] Starting 'publish-preview'...
           C:\Users\ci\AppData\Local\Temp\PUBLISHugt8j\11_20170922T214144\autorest.modeler :: npm publish --tag preview
Exec Failed C:\Users\ci\AppData\Local\Temp\PUBLISHugt8j\11_20170922T214144\autorest.modeler :: npm publish --tag preview
(stderr)
  npm ERR! path C:\Users\ci\AppData\Local\Temp\npm-6884-66801625\tmp\fromDir-ce3fd6d9\package.tgz
    npm ERR! code EPERM
    npm ERR! errno -4048
    npm ERR! syscall unlink
    npm ERR! Error: EPERM: operation not permitted, unlink 'C:\Users\ci\AppData\Local\Temp\npm-6884-66801625\tmp\fromDir-ce3fd6d9\package.tgz'
    npm ERR!  { Error: EPERM: operation not permitted, unlink 'C:\Users\ci\AppData\Local\Temp\npm-6884-66801625\tmp\fromDir-ce3fd6d9\package.tgz'
    npm ERR!   cause: 
    npm ERR!    { Error: EPERM: operation not permitted, unlink 'C:\Users\ci\AppData\Local\Temp\npm-6884-66801625\tmp\fromDir-ce3fd6d9\package.tgz'
    npm ERR!      errno: -4048,
    npm ERR!      code: 'EPERM',
    npm ERR!      syscall: 'unlink',
    npm ERR!      path: 'C:\Users\ci\AppData\Local\Temp\npm-6884-66801625\tmp\fromDir-ce3fd6d9\package.tgz' },
    npm ERR!   isOperational: true,
    npm ERR!   stack: 'Error: EPERM: operation not permitted, unlink \'C:\Users\ci\AppData\Local\Temp\npm-6884-66801625\tmp\fromDir-ce3fd6d9\package.tgz\'',
    npm ERR!   errno: -4048,
    npm ERR!   code: 'EPERM',
    npm ERR!   syscall: 'unlink',
    npm ERR!   path: 'C:\Users\ci\AppData\Local\Temp\npm-6884-66801625\tmp\fromDir-ce3fd6d9\package.tgz' }
    npm ERR! 
    npm ERR! Please try running this command again as root/Administrator.

npm ERR! A complete log of this run can be found in:
npm ERR!     C:\Users\ci\AppData\Roaming\npm-cache_logs\2017-09-22T21_44_28_337Z-debug.log


(stdout)

> @microsoft.azure/autorest.modeler@2.0.14 prepare .
> gulp build

[14:43:55] Using gulpfile ~\AppData\Local\Temp\PUBLISHugt8j\11_20170922T214144\autorest.modeler\gulpfile.js
[14:43:55] Starting 'init'...
[14:43:55] Finished 'init' after 347 μs
[14:43:55] Starting 'clear-cache-on-force'...
[14:43:55] Finished 'clear-cache-on-force' after 117 μs
[14:43:55] Starting 'restore'...
[14:43:55] Starting 'version-number'...
[14:43:56] Finished 'version-number' after 1.48 s
[14:43:56] Finished 'restore' after 1.59 s
[14:43:56] Starting 'build/dotnet'...
           C:\Users\ci\AppData\Local\Temp\PUBLISHugt8j\11_20170922T214144\autorest.modeler :: dotnet build -c Debug C:\Users\ci\AppData\Local\Temp\PUBLISHugt8j\11_20170922T214144\autorest.modeler/autorest.modeler.sln /nologo /clp:NoSummary /p:VersionPrefix=2.0.14
           C:\Users\ci\AppData\Local\Temp\PUBLISHugt8j\11_20170922T214144\autorest.modeler :: dotnet publish -c Debug C:\Users\ci\AppData\Local\Temp\PUBLISHugt8j\11_20170922T214144\autorest.modeler/src/ --output C:\Users\ci\AppData\Local\Temp\PUBLISHugt8j\11_20170922T214144\autorest.modeler/src//bin/netcoreapp2.0 /nologo /clp:NoSummary /p:VersionPrefix=2.0.14
[14:44:25] Finished 'build/dotnet' after 29 s
[14:44:25] Starting 'build'...
Building project in C:\Users\ci\AppData\Local\Temp\PUBLISHugt8j\11_20170922T214144\autorest.modeler
[14:44:25] Finished 'build' after 140 μs


Task Failed:  Execute Task failed, fast exit

npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! @microsoft.azure/autorest.modeler@2.0.0 publish-preview: `gulp publish-preview`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the @microsoft.azure/autorest.modeler@2.0.0 publish-preview script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     C:\Users\ci\AppData\Roaming\npm-cache\_logs\2017-09-22T21_44_28_681Z-debug.log

@fearthecowboy
Copy link
Member

I've published this from my local machine:

[14:50:12] Using gulpfile C:\work\github\autorest\autorest.modeler\gulpfile.js
[14:50:12] Starting 'init'...
[14:50:12] Finished 'init' after 588 μs
[14:50:12] Starting 'version-number'...
[14:50:12] Finished 'version-number' after 56 ms
[14:50:12] Starting 'publish-preview'...
           C:\work\github\autorest\autorest.modeler :: npm publish --tag preview


Published:  @microsoft.azure/autorest.modeler@2.0.14 (tagged as @preview)


[14:50:24] Finished 'publish-preview' after 11 s

@olydis olydis deleted the revert-9-enumfix2 branch September 22, 2017 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants