-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Add x-ms-enum's default to SwaggerObject." #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@olydis, |
publish jobfailed
|
I've published this from my local machine: [14:50:12] Using gulpfile C:\work\github\autorest\autorest.modeler\gulpfile.js
[14:50:12] Starting 'init'...
[14:50:12] Finished 'init' after 588 μs
[14:50:12] Starting 'version-number'...
[14:50:12] Finished 'version-number' after 56 ms
[14:50:12] Starting 'publish-preview'...
C:\work\github\autorest\autorest.modeler :: npm publish --tag preview
Published: @microsoft.azure/autorest.modeler@2.0.14 (tagged as @preview)
[14:50:24] Finished 'publish-preview' after 11 s
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #9
@amarzavery as far as we can see, this breaks every single generator (NRE's in C#, huge diff in Java, weird change in ARS, ...). We can look at this again after the release.
E.g. take a look at http://autorestci1.blob.core.windows.net/autorest-ci/CImdygk_autorest.nodejs_9_20170922T213752