Adding model properties or parameters with "enum" constraint to the codeModel as EnumType with modelAsString: true

[amarzavery]

• We were previously treating such model properties and parameters as enums with ModelAsString true anyway. This PR adds them to the codeModel thus making the circle complete.
• Once the PR is merged, codegenerators taking a dependency on the modeler with this this change will see an extra model in their library (For example: A static class with constant properties in case of C#)
• There should be no breaking changes to the generated client.

[msftclas]

@amarzavery,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

[olydis]

wow how was enum color ever a valid declaration... I love our tests

[amarzavery]

We simply wanted tests to pass.. ROFL

[olydis]

thanks for the nice commenting :) 👍

[amarzavery]

I found more issues after using the updated modeler locally with the TS generator.
In our test swaggers at lot of places we are using the swagger enums "enum": [..] without the x-ms-enum extension. These enum contain weird values for example:

• An empty string enum "enum": [""] generates in TS enum Foo { = "" } which is invalid. The member name should be sanitized to EMPTY_STRING.
  Other cases were of strings like /http/put/201; where slashes make the member name invalid.

One case was of enum containing MBCS encoding chinese characters.

We can sanitize them in the modeler or do this in every generator.

[olydis]

oh dear... there actually is a sanitation method somewhere but not sure who calls it and when - I would have expected it to at least handle the slashes. But yeah, empty string and non-ASCII characters should be sanitized too, ideally by extending that function

[fearthecowboy]

LGTM +1

We should generate a whole bunch of the rest-specs and see if there is any problems.