Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support enum #643

Merged
merged 3 commits into from
Jul 29, 2020
Merged

Support enum #643

merged 3 commits into from
Jul 29, 2020

Conversation

shawncx
Copy link
Contributor

@shawncx shawncx commented Jul 28, 2020

  1. add support for enum (no test cover yet)
  2. add more test
  • "component-param",
  • "component-multiparam",
  • "component-param-localremote",
  • "component-param-inbody"

dolauli
dolauli requested changes Jul 29, 2020
View reviewed changes
Copy link
Contributor

@dolauli dolauli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, except for a minor issue in previous change

powershell/autorest-configuration.md Outdated Show resolved Hide resolved
@dolauli dolauli merged commit 67674b2 into Azure:modelerfour Jul 29, 2020
dolauli added a commit that referenced this pull request Oct 19, 2020
@dolauli @LucasYao93
@dingmeng-xue @shawncx @msxichen @Youri970410 @isra-fel @VeryEarly
Merge m4 to master branch (#700)
c22c4e2 
* Support for simple API with modelerfour(defined in xkcd.ymal)

* Move some libs from modeler-v3 to autorest.powershell and remove modeler-v3 dependency in the new plugins

* Reimplement CmdletClass based on modelerfour

* Add support for basic types like integer/number/array/boolean/.etc

* Add test cases for upgrade.

* Init ADO pipeline for PR verification (#626)

* Add dummy code

* Change file name

* Update code

* Add PowerShell task

* Update code

* Correct displayName

* Fix typo

* Add virtual properties and fix a few issues (#628)

* Support parameter path - llcsharp (#629)

* add tweak-model-azure-v2 plugin

* support path parameter (llcsharp)

* fix comment

* fix comment

* Fix some issues in powershell-v2

Co-authored-by: xichen <xichen@microsoft.com>
Co-authored-by: derek <xidi@microsoft.com>

* Add azure support for get with an empty response (#634)

* Add validation script in pipeline (#630)

* Add -AllowList

* Add scripts and configuration

* Add build steps

* Change work directory

* Enable AutoRestUpgradeTest.ps1.

* Add save artifacts task

* Revert "Enable AutoRestUpgradeTest.ps1."

This reverts commit 66c750d.

* Update the script

Co-authored-by: Youri <v-lipyo@microsoft.com>

* Add support for default response and fix an issue related to model (#635)

* enable the test cases basic-get and basic-get-delete (#636)

* Add another 9 test cases that has been supported (#638)

* Change the script (#639)

* Update test-module-upgrade.yml

* Update test-module-upgrade.yml, should use core instead of window powershell for pipeline

* Remove unpassed cases and upgrade codemodel dependency (#641)

* support request body (#637)

* support request body

* fix query parameter and no-requried parameter

* fix readonly

* fix diff between m3 and m4

Co-authored-by: xichen <xichen@microsoft.com>

* Change the AutoRestUpgrade.ps1 for different Powershell version (#642)

* Change the script

* add script tips

* fix the powershell version issue

* Fix formatting issues

* Support enum (#643)

* support enum

* fix diff from m3

* llcsharp-v2 should rely on modifiers-v2

Co-authored-by: xichen <xichen@microsoft.com>
Co-authored-by: Xiaogang <xidi@microsoft.com>

* Initial support for lro and paing (#644)

* Initial support for lro and pagination

* Fixed a paging issue

* Fix the issue nested object is not supported (#646)

* Fix the issue nested ojbect not supported

* Add more passed test cases

* Add support for allof, datetime and enable two cases (#649)

* Fix the issue nested ojbect not supported

* Add more passed test cases

* Add support for allOf, datetime and enable two cases

* support header (#648)

* support header

* fix some issue for enum and header

* fix choice

* fix enum

* Only validate sealedchoice

Co-authored-by: xichen <xichen@microsoft.com>
Co-authored-by: Xiaogang <xidi@microsoft.com>

* Add test cases of autorest extension. (#647)

* Add test cases of autorest extension.

* Add test cases of directive.

* Add test case of directive.

* Intial support for polymorphism (#650)

* Fix the issue nested ojbect not supported

* Add more passed test cases

* Add support for allOf, datetime and enable two cases

* initial poly support

* Add a test for polymorphism

* Add support for duration and uuid (#652)

* Fix the issue nested ojbect not supported

* Add more passed test cases

* Add support for allOf, datetime and enable two cases

* initial poly support

* Add a test for polymorphism

* Add support for uuid and duration

* Add test cases to AllowList. (#653)

* Add test cases of autorest extension.

* Add test cases of directive.

* Add test case of directive.

* Add test cases to AllowList.

* support dict (#651)

Co-authored-by: xichen <xichen@microsoft.com>

* Add test cases of data model. (#654)

* Add test cases of autorest extension.

* Add test cases of directive.

* Add test case of directive.

* Add test cases to AllowList.

* Add test cases of datamodels.

* Update AllList.

* Add databricks, fix several issues (#658)

* SupportDateTimeRfc1123 (#657)

* SupportDateTimeRfc1123

* fix

Co-authored-by: xichen <xichen@microsoft.com>

* Fix the BlackList issue (#656)

* Fix the BlackList issue

* Fix Create CompareResult Folder Issue

It will not create 'CompareResult' folder if the file exists.

* Fixed a completer related issue and add support for credential (#660)

* Add databricks, fix several issues

* Fixed a completer related issue and add support for credential

* Enable 3 test cases (#659)

* enable test cases

* disable datamodels-datatypes-object, cause we cannot handle any yet

* fix dup name issue

* fix comment

Co-authored-by: xichen <xichen@microsoft.com>

* Fix some issues (#663)

Co-authored-by: xichen <xichen@microsoft.com>

* Update some test cases (#661)

* Update some testcase

Add some testcases and delete some failed testcases

* Revert "Update some testcase"

This reverts commit 38b9e87.

* Submit some test cases and fix some problems with the script

* Add two m4 configuration and fix some issues (#664)

* Add databricks, fix several issues

* Fixed a completer related issue and add support for credential

* Add two m4 configuration and fix some issues

* Add support for enum with one value (#666)

* Add databricks, fix several issues

* Fixed a completer related issue and add support for credential

* Add two m4 configuration and fix some issues

* Add support for enum with one value

* fix some issues (#665)

Co-authored-by: xichen <xichen@microsoft.com>
Co-authored-by: Xiaogang <xidi@microsoft.com>

* fix header issue (#667)

Co-authored-by: xichen <xichen@microsoft.com>

* Fixed an enum related issue and add some RPs in the test (#669)

* Add databricks, fix several issues

* Fixed a completer related issue and add support for credential

* Add two m4 configuration and fix some issues

* Add support for enum with one value

* Fixed an enum related issue and add some RPs in the test

* Fix some issues in m4 test (#671)

* Add databricks, fix several issues

* Fixed a completer related issue and add support for credential

* Add two m4 configuration and fix some issues

* Add support for enum with one value

* Fixed an enum related issue and add some RPs in the test

* Fix some issues in m4 test

* skip content type request parameter (#673)

Co-authored-by: xichen <xichen@microsoft.com>

* Use the latest m4 (#674)

* Add databricks, fix several issues

* Fixed a completer related issue and add support for credential

* Add two m4 configuration and fix some issues

* Add support for enum with one value

* Fixed an enum related issue and add some RPs in the test

* Fix some issues in m4 test

* just for test, do not merge

* Update autorest-configuration.md

* Fix choice issue (#675)

Co-authored-by: xichen <xichen@microsoft.com>

* Fix enum boolean response which has only one value (#676)

Co-authored-by: xichen <xichen@microsoft.com>

* Enable two test cases, and drop the workaround for x-ms-enum (#677)

* Upgrade modelerfour to 4.15.414 (#679)

* Add utils folder include a script to decrypt securestring (#682)

* Enable two test cases, and drop the workaround for x-ms-enum

* Add utils folder include a script to decrypt securestring

* fix deserialize dictionary value bug (#684)

* Generate model for all the dictionaries and add support for unixtime (#685)

* Enable two test cases, and drop the workaround for x-ms-enum

* Add utils folder include a script to decrypt securestring

* Generate model for all the dictionaries and add support for unixtime

* git clone need not --recurse (#686)

* handle duplicated properties in parentes, fixes #688 (#690)

* handle duplicated properties in parentes, fixes #688

* Remove no-needed comments

* Add support for no-inline (#691)

* Add support support for API, whose request body is just an object without specifying any details (#694)

* M4 master merge (#695)

* Emit Signal method and delegate to provide a hook into events

* Update Az.Accounts dependency to 1.8.4

* Adding target attribute to nuspec file elements

* Using backslash path separator in nuspec for cross platform compatability

* Remove Init method constructor call.

* Revert "Emit Signal method and delegate to provide a hook into events"

* Emit Signal method and delegate to provide hook into events for Non-Azure scenarios.

* Update ISendAsync.cs (#662)

* Update ISendAsync.cs

pass only Authorization to next header for long running operations.

* Update ISendAsync.cs

* Update ISendAsync.cs

fix potential null reference

* Update ISendAsync.cs

* Update ISendAsync.cs

* Update ISendAsync.cs

* update gitignore (#670)

* Add scan pipelines (#681)

* Update development.md - add how to debug (#683)

* Update development.md

* Update development.md

* Fix some merging issues

Co-authored-by: George Ndungu <gendungu@microsoft.com>
Co-authored-by: Tim Mullender <tim.mullender@wandisco.com>
Co-authored-by: Yabo Hu <yabhu@microsoft.com>
Co-authored-by: Yeming Liu <Yeming.Liu@microsoft.com>
Co-authored-by: Dingmeng Xue <dixue@microsoft.com>

* Upgrade rush and pnpm (#697)

* Clean m3 related steps from the pipeline (#699)

* Clean m3 related steps from the pipeline

* clean m3 plugins and update related tests accordingly

* clean code used by m3 generator

* Remove the prefix New

* Remove New from types

* upgrade version to 3.0.0

* Remove some useless comments

Co-authored-by: LucasYao93 <53558334+LucasYao93@users.noreply.github.com>
Co-authored-by: Dingmeng Xue <56333063+dingmeng-xue@users.noreply.github.com>
Co-authored-by: xichen <braincx@gmail.com>
Co-authored-by: xichen <xichen@microsoft.com>
Co-authored-by: Youri <v-lipyo@microsoft.com>
Co-authored-by: Youri970410 <62531040+Youri970410@users.noreply.github.com>
Co-authored-by: Yeming Liu <Yeming.Liu@microsoft.com>
Co-authored-by: George Ndungu <gendungu@microsoft.com>
Co-authored-by: Tim Mullender <tim.mullender@wandisco.com>
Co-authored-by: Yabo Hu <yabhu@microsoft.com>
Co-authored-by: Dingmeng Xue <dixue@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dolauli dolauli dolauli requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shawncx @dolauli @msxichen