Advanced multipart implementation #2740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…advanced-multipart-implementation
…m/Azure/autorest.python into advanced-multipart-implementation
msyyc
changed the title
msyyc
commented
Aug 14, 2024
| @@ -165,6 +165,9 @@ async function getSubdirectories(baseDir: string, flags: RegenerateFlags): Promi | |||
| // after xml support, remove this check | |||
| if (mainTspRelativePath.includes("xml")) return; | |||
|
|
|||
| // after fix test generation for nested operation group, remove this check | |||
| if (mainTspRelativePath.includes("client-operation-group")) return; | |||
|
|
|||
There was a problem hiding this comment.
Will make another PR to fix test generation for this case
msyyc
commented
Aug 14, 2024
packages/typespec-python/generator/pygen/codegen/models/primitive_types.py
Outdated
Show resolved
Hide resolved
iscai-msft
reviewed
Aug 14, 2024
packages/typespec-python/generator/pygen/codegen/serializers/model_serializer.py
Outdated
Show resolved
Hide resolved
iscai-msft
reviewed
Aug 14, 2024
msyyc
commented
Aug 16, 2024
| codeModel["subnamespaceToClients"][client.nameSpace] = emitClient(sdkContext, client); | ||
| } | ||
| } | ||
| // loop through models and enums since there may be some orphaned models needs to be generated | ||
| for (const model of sdkPackage.models) { |
There was a problem hiding this comment.
Put loop for models/enums behind emitClients so that we could collect models which will not be generated (e.g. models for multipart file part) and disable them by not calling getType to add them into typesMap
msyyc
commented
Aug 16, 2024
| @@ -624,3 +624,29 @@ def instance_check_template(self) -> str: | |||
| @property | |||
| def serialization_type(self) -> str: | |||
| return self.name | |||
|
|
|||
|
|
|||
| class MultiPartFileType(PrimitiveType): | |||
There was a problem hiding this comment.
With the new type, we don't need special logic in docstring/typing annotation for multipart properties anymore. And it is much easier to evolve in the future.
tadelesh
reviewed
Aug 19, 2024
tadelesh
approved these changes
Aug 20, 2024
iscai-msft
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #2489 and #2488
bodyParamofSdkHttpOperationtypespec-azure#1281HttpPartcadl-ranch#613