Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build error #2722

Merged
merged 3 commits into from
Aug 1, 2024
Merged

Fix build error #2722

merged 3 commits into from
Aug 1, 2024

Conversation

v-jiaodi
Copy link
Member

@v-jiaodi v-jiaodi commented Aug 1, 2024

@MaryGao MaryGao marked this pull request as ready for review August 1, 2024 07:47
lirenhe
lirenhe reviewed Aug 1, 2024
View reviewed changes
packages/typespec-ts/src/modular/buildCodeModel.ts
@@ -1231,17 +1231,32 @@ function applyEncoding(

function mergeFormatAndEncoding(
format: string | undefined,
encoding: string,
encoding: string | undefined,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need any test case for this?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

currently we can't, but we could include test cases in #2676.

the case could be prepared when encode int as string is released.

@MaryGao MaryGao merged commit 124ff9b into Azure:main Aug 1, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lirenhe lirenhe lirenhe left review comments

@MaryGao MaryGao MaryGao approved these changes

@sarangan12 sarangan12 Awaiting requested review from sarangan12 sarangan12 is a code owner

@joheredi joheredi Awaiting requested review from joheredi joheredi is a code owner

@qiaozha qiaozha Awaiting requested review from qiaozha qiaozha is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@v-jiaodi @lirenhe @MaryGao