Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add client namespace and update test case #2994

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Add client namespace and update test case #2994

wants to merge 11 commits into from

Conversation

v-jiaodi
Copy link
Member

@v-jiaodi v-jiaodi commented Jan 13, 2025 •
edited
Loading

fixes #3045

@v-jiaodi v-jiaodi changed the title Update test case Add client namespace and update test case Feb 5, 2025
MaryGao
MaryGao reviewed Feb 13, 2025
View reviewed changes
packages/typespec-ts/test/azureModularIntegration/generated/client/namespace/src/index.d.ts
import { OperationOptions } from '@azure-rest/core-client';
import { Pipeline } from '@azure/core-rest-pipeline';

export declare class ClientNamespaceFirstClient {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add the js decorator part in spector side? https://github.com/Azure/typespec-azure/pull/1929/files#r1953860516

MaryGao
MaryGao reviewed Feb 13, 2025
View reviewed changes
packages/typespec-ts/test/azureModularIntegration/generated/client/namespace/tspconfig.yaml
- "@azure-tools/typespec-ts"
options:
"@azure-tools/typespec-ts":
"emitter-output-dir": "{project-root}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you try if the namesapce is udpated after spec changed with option enableModelNamespace and enableOperationGroup ?

MaryGao
MaryGao requested changes Feb 13, 2025
View reviewed changes
Copy link
Member

@MaryGao MaryGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to update the spec first and then update our test config to verify this change.

@MaryGao MaryGao marked this pull request as ready for review February 13, 2025 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaryGao MaryGao MaryGao requested changes

@joheredi joheredi Awaiting requested review from joheredi joheredi is a code owner

@qiaozha qiaozha Awaiting requested review from qiaozha qiaozha is a code owner

Requested changes must be addressed to merge this pull request.

Assignees

@MaryGao MaryGao

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Supplement client namespace service case for azure spector
2 participants
@v-jiaodi @MaryGao