Skip to content

Fix spread body parameter for generating sample #3618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
v-jiaodi wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix spread body parameter for generating sample #3618

v-jiaodi wants to merge 2 commits into from

Conversation

@v-jiaodi
Copy link
Member

@v-jiaodi v-jiaodi commented Nov 27, 2025

fixes #3614

@v-jiaodi v-jiaodi marked this pull request as ready for review December 1, 2025 02:53
@qiaozha qiaozha added the p0 priority 0 label Dec 3, 2025
MaryGao
MaryGao reviewed Dec 4, 2025
View reviewed changes
packages/typespec-ts/src/modular/emitSamples.ts
const bodyParam = method.operation.bodyParam;
const bodySerializeName = bodyParam?.serializedName;
const bodyExample = parameterMap[bodySerializeName ?? ""];
if (bodySerializeName && bodyExample && bodyExample.value) {
Copy link
Member

@MaryGao MaryGao Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to add a UT: https://github.com/Azure/autorest.typescript/blob/main/packages/typespec-ts/test/modularUnit/scenarios/samples/parameters/paramaterSpreadCheck.md#L37.

MaryGao
MaryGao reviewed Dec 4, 2025
View reviewed changes
packages/typespec-ts/src/modular/emitSamples.ts
// required/optional body parameters
const bodyParam = method.operation.bodyParam;
const bodySerializeName = bodyParam?.serializedName;
const bodyExample = parameterMap[bodySerializeName ?? ""];
Copy link
Member

@MaryGao MaryGao Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if bodySerializeName is empty, how do we get bodyExample in parameterMap?

@qiaozha qiaozha added P1 priority 1 and removed p0 priority 0 labels Dec 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MaryGao MaryGao MaryGao left review comments

@joheredi joheredi Awaiting requested review from joheredi joheredi is a code owner

@qiaozha qiaozha Awaiting requested review from qiaozha qiaozha is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@MaryGao MaryGao

Labels

P1 priority 1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[sample gen] Spread body parameter is not handled correctly

3 participants

@v-jiaodi @MaryGao @qiaozha