Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple clean up fixes for JSDoc and parameter handling #557

Merged
merged 3 commits into from
Jan 31, 2020
Merged

Multiple clean up fixes for JSDoc and parameter handling #557

merged 3 commits into from
Jan 31, 2020

Conversation

joheredi
Copy link
Member

This PR includes:

  • Wrap long comments to maximum width
  • Simplify optional parameter handling in ClientContext
  • Make credentials parameter a "Synthetic" parameter next to SWAGGER parameters to avoid having special hanlding for it
  • Add missing JSDoc to Client, and ClientContext

@joheredi joheredi requested a review from daviwil January 31, 2020 19:56
daviwil
daviwil approved these changes Jan 31, 2020
View reviewed changes
Copy link
Contributor

@daviwil daviwil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple minor things here and there but overall LGTM

src/generators/clientFileGenerator.ts Outdated Show resolved Hide resolved
src/transforms/parameterTransforms.ts Outdated Show resolved Hide resolved
src/typescriptGenerator.ts Outdated Show resolved Hide resolved
test/integration/generated/bodyComplex/src/operations/array.ts Outdated Show resolved Hide resolved
@joheredi joheredi merged commit a8e07f3 into Azure:v6 Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daviwil daviwil daviwil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joheredi @daviwil