Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rush and pnpm to support node 12 and 14 #3713

Merged
merged 2 commits into from
Dec 1, 2020

Conversation

timotheeguerin
Copy link
Member

@timotheeguerin timotheeguerin commented Dec 1, 2020

Node 10 is ending its life in april 2021. Current active LTS version is Node 14.

This PR updates rush and pnpm which supports node 12 and 14

Tested rush install and rush build on Node 10, 12 and 14

Seems to be an issue with node 13 in the PR validation build(nodejs/node#31029). It also seems like there is 3 different version of node used in the 3 piplines:

  • publish.yaml: 10
  • push-to-npm: 12
  • verify-pull-request: 13 -> 14

@timotheeguerin
Copy link
Member Author

I see here common/config/rush/shrinkwrap.yaml was in the gitignore but not in autorest.megarepo. Should pnpm-lock.yaml file be? I think it defeat the point of lock files.

@daviwil
Copy link
Contributor

daviwil commented Dec 1, 2020

Looks like the azure-sdk-for-js repo checks in the pnpm-lock.yaml file, I'm not sure where the shrinkwrap file comes from

@timotheeguerin
Copy link
Member Author

Not familiar with pnpm or rush but I think that used to be the old name for the same file, In the megarepo PR:
image

@daviwil
Copy link
Contributor

daviwil commented Dec 1, 2020

Interesting, I'd say let's leave it checked in for now and we can remove it if we run into problems. CI is green so I'm going to merge this. Thanks a bunch!

@daviwil daviwil merged commit 095c56e into master Dec 1, 2020
@timotheeguerin timotheeguerin deleted the feature/support-node-12-14 branch December 1, 2020 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants