Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set autorest.powershell v4 as default version loaded by autorest #4793

Merged
merged 3 commits into from
Nov 16, 2023

Conversation

dolauli
Copy link
Contributor

@dolauli dolauli commented Nov 15, 2023

Change the default version of autorest.powershell loaded by autorest from 3.0+ to 4.0+.

@dolauli dolauli marked this pull request as ready for review November 15, 2023 07:35
@dolauli
Copy link
Contributor Author

dolauli commented Nov 15, 2023

@timotheeguerin Could you please help review and merge my change? We had a similar update two years ago when we transitioned autorest.powershell from 2.1+ to 3.0+.

BTW, the CI failure seems not caused by my change.

@timotheeguerin
Copy link
Member

Have a pr here that should solve the ci bug, #4794

but somehow I cannot merge PRs anymore in autorest. MIght have been due to the permission cleanup

@dolauli
Copy link
Contributor Author

dolauli commented Nov 16, 2023

Have a pr here that should solve the ci bug, #4794

but somehow I cannot merge PRs anymore in autorest. MIght have been due to the permission cleanup

Hi Tim, Thanks a lot for helping review the PR. Do you know who may have the permission to merge the PR? Or I have to wait for you to re-apply the permission.

@timotheeguerin
Copy link
Member

I got the permission back but the failure is still happening, now seems to be a problem with @autorest/python installing

@timotheeguerin timotheeguerin enabled auto-merge (squash) November 16, 2023 03:59
@timotheeguerin timotheeguerin merged commit 980e2f5 into Azure:main Nov 16, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants