Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added "gets or sets" rule for the model template in the CSharp code generator #989

Closed
wants to merge 19 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
Original file line number Diff line number Diff line change
Expand Up @@ -36,14 +36,14 @@ public partial class AutoRestDurationTestService : ServiceClient<AutoRestDuratio
public Uri BaseUri { get; set; }

/// <summary>
/// Gets or sets json serialization settings.
/// Gets the JSON serialization settings.
/// </summary>
public JsonSerializerSettings SerializationSettings { get; private set; }

/// <summary>
/// Gets or sets json deserialization settings.
/// Gets the JSON deserialization settings.
/// </summary>
public JsonSerializerSettings DeserializationSettings { get; private set; }
public JsonSerializerSettings DeserializationSettings { get; private set; }

/// <summary>
/// Gets Azure subscription credentials.
Expand Down Expand Up @@ -76,7 +76,7 @@ public partial class AutoRestDurationTestService : ServiceClient<AutoRestDuratio
/// Initializes a new instance of the AutoRestDurationTestService class.
/// </summary>
/// <param name='handlers'>
/// Optional. The delegating handlers to add to the http client pipeline.
/// Optional. The delegating handlers to add to the HTTP pipeline.
/// </param>
protected AutoRestDurationTestService(params DelegatingHandler[] handlers) : base(handlers)
{
Expand All @@ -87,10 +87,10 @@ protected AutoRestDurationTestService(params DelegatingHandler[] handlers) : bas
/// Initializes a new instance of the AutoRestDurationTestService class.
/// </summary>
/// <param name='rootHandler'>
/// Optional. The http client handler used to handle http transport.
/// Optional. The HTTP client handler used to handle HTTP transport.
/// </param>
/// <param name='handlers'>
/// Optional. The delegating handlers to add to the http client pipeline.
/// Optional. The delegating handlers to add to the HTTP pipeline.
/// </param>
protected AutoRestDurationTestService(HttpClientHandler rootHandler, params DelegatingHandler[] handlers) : base(rootHandler, handlers)
{
Expand All @@ -104,7 +104,7 @@ protected AutoRestDurationTestService(HttpClientHandler rootHandler, params Dele
/// Optional. The base URI of the service.
/// </param>
/// <param name='handlers'>
/// Optional. The delegating handlers to add to the http client pipeline.
/// Optional. The delegating handlers to add to the HTTP pipeline.
/// </param>
protected AutoRestDurationTestService(Uri baseUri, params DelegatingHandler[] handlers) : this(handlers)
{
Expand All @@ -122,10 +122,10 @@ protected AutoRestDurationTestService(Uri baseUri, params DelegatingHandler[] ha
/// Optional. The base URI of the service.
/// </param>
/// <param name='rootHandler'>
/// Optional. The http client handler used to handle http transport.
/// Optional. The HTTP client handler used to handle HTTP transport.
/// </param>
/// <param name='handlers'>
/// Optional. The delegating handlers to add to the http client pipeline.
/// Optional. The delegating handlers to add to the HTTP pipeline.
/// </param>
protected AutoRestDurationTestService(Uri baseUri, HttpClientHandler rootHandler, params DelegatingHandler[] handlers) : this(rootHandler, handlers)
{
Expand All @@ -143,7 +143,7 @@ protected AutoRestDurationTestService(Uri baseUri, HttpClientHandler rootHandler
/// Required. Gets Azure subscription credentials.
/// </param>
/// <param name='handlers'>
/// Optional. The delegating handlers to add to the http client pipeline.
/// Optional. The delegating handlers to add to the HTTP pipeline.
/// </param>
public AutoRestDurationTestService(ServiceClientCredentials credentials, params DelegatingHandler[] handlers) : this(handlers)
{
Expand All @@ -165,10 +165,10 @@ public AutoRestDurationTestService(ServiceClientCredentials credentials, params
/// Required. Gets Azure subscription credentials.
/// </param>
/// <param name='rootHandler'>
/// Optional. The http client handler used to handle http transport.
/// Optional. The HTTP client handler used to handle HTTP transport.
/// </param>
/// <param name='handlers'>
/// Optional. The delegating handlers to add to the http client pipeline.
/// Optional. The delegating handlers to add to the HTTP pipeline.
/// </param>
public AutoRestDurationTestService(ServiceClientCredentials credentials, HttpClientHandler rootHandler, params DelegatingHandler[] handlers) : this(rootHandler, handlers)
{
Expand All @@ -193,7 +193,7 @@ public AutoRestDurationTestService(ServiceClientCredentials credentials, HttpCli
/// Required. Gets Azure subscription credentials.
/// </param>
/// <param name='handlers'>
/// Optional. The delegating handlers to add to the http client pipeline.
/// Optional. The delegating handlers to add to the HTTP pipeline.
/// </param>
public AutoRestDurationTestService(Uri baseUri, ServiceClientCredentials credentials, params DelegatingHandler[] handlers) : this(handlers)
{
Expand Down Expand Up @@ -223,10 +223,10 @@ public AutoRestDurationTestService(Uri baseUri, ServiceClientCredentials credent
/// Required. Gets Azure subscription credentials.
/// </param>
/// <param name='rootHandler'>
/// Optional. The http client handler used to handle http transport.
/// Optional. The HTTP client handler used to handle HTTP transport.
/// </param>
/// <param name='handlers'>
/// Optional. The delegating handlers to add to the http client pipeline.
/// Optional. The delegating handlers to add to the HTTP pipeline.
/// </param>
public AutoRestDurationTestService(Uri baseUri, ServiceClientCredentials credentials, HttpClientHandler rootHandler, params DelegatingHandler[] handlers) : this(rootHandler, handlers)
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ internal DurationOperations(AutoRestDurationTestService client)
/// Get null duration value
/// </summary>
/// <param name='customHeaders'>
/// Headers that will be added to request.
/// Headers that will be added to the request.
/// </param>
/// <param name='cancellationToken'>
/// The cancellation token.
Expand Down Expand Up @@ -201,7 +201,7 @@ internal DurationOperations(AutoRestDurationTestService client)
/// <param name='durationBody'>
/// </param>
/// <param name='customHeaders'>
/// Headers that will be added to request.
/// Headers that will be added to the request.
/// </param>
/// <param name='cancellationToken'>
/// The cancellation token.
Expand Down Expand Up @@ -336,7 +336,7 @@ internal DurationOperations(AutoRestDurationTestService client)
/// Get a positive duration value
/// </summary>
/// <param name='customHeaders'>
/// Headers that will be added to request.
/// Headers that will be added to the request.
/// </param>
/// <param name='cancellationToken'>
/// The cancellation token.
Expand Down Expand Up @@ -482,7 +482,7 @@ internal DurationOperations(AutoRestDurationTestService client)
/// Get an invalid duration value
/// </summary>
/// <param name='customHeaders'>
/// Headers that will be added to request.
/// Headers that will be added to the request.
/// </param>
/// <param name='cancellationToken'>
/// The cancellation token.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,12 +29,12 @@ public partial interface IAutoRestDurationTestService : IDisposable
Uri BaseUri { get; set; }

/// <summary>
/// Gets or sets json serialization settings.
/// Gets the JSON serialization settings.
/// </summary>
JsonSerializerSettings SerializationSettings { get; }

/// <summary>
/// Gets or sets json deserialization settings.
/// Gets the JSON deserialization settings.
/// </summary>
JsonSerializerSettings DeserializationSettings { get; }

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ public partial interface IDurationOperations
/// Get null duration value
/// </summary>
/// <param name='customHeaders'>
/// The headers that will be added to request.
/// The headers that will be added to the request.
/// </param>
/// <param name='cancellationToken'>
/// The cancellation token.
Expand All @@ -38,7 +38,7 @@ public partial interface IDurationOperations
/// <param name='durationBody'>
/// </param>
/// <param name='customHeaders'>
/// The headers that will be added to request.
/// The headers that will be added to the request.
/// </param>
/// <param name='cancellationToken'>
/// The cancellation token.
Expand All @@ -48,7 +48,7 @@ public partial interface IDurationOperations
/// Get a positive duration value
/// </summary>
/// <param name='customHeaders'>
/// The headers that will be added to request.
/// The headers that will be added to the request.
/// </param>
/// <param name='cancellationToken'>
/// The cancellation token.
Expand All @@ -58,7 +58,7 @@ public partial interface IDurationOperations
/// Get an invalid duration value
/// </summary>
/// <param name='customHeaders'>
/// The headers that will be added to request.
/// The headers that will be added to the request.
/// </param>
/// <param name='cancellationToken'>
/// The cancellation token.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ internal ArrayOperations(AzureCompositeModel client)
/// Get complex types with array property
/// </summary>
/// <param name='customHeaders'>
/// Headers that will be added to request.
/// Headers that will be added to the request.
/// </param>
/// <param name='cancellationToken'>
/// The cancellation token.
Expand Down Expand Up @@ -201,7 +201,7 @@ internal ArrayOperations(AzureCompositeModel client)
/// <param name='array'>
/// </param>
/// <param name='customHeaders'>
/// Headers that will be added to request.
/// Headers that will be added to the request.
/// </param>
/// <param name='cancellationToken'>
/// The cancellation token.
Expand Down Expand Up @@ -341,7 +341,7 @@ internal ArrayOperations(AzureCompositeModel client)
/// Get complex types with array property which is empty
/// </summary>
/// <param name='customHeaders'>
/// Headers that will be added to request.
/// Headers that will be added to the request.
/// </param>
/// <param name='cancellationToken'>
/// The cancellation token.
Expand Down Expand Up @@ -489,7 +489,7 @@ internal ArrayOperations(AzureCompositeModel client)
/// <param name='array'>
/// </param>
/// <param name='customHeaders'>
/// Headers that will be added to request.
/// Headers that will be added to the request.
/// </param>
/// <param name='cancellationToken'>
/// The cancellation token.
Expand Down Expand Up @@ -630,7 +630,7 @@ internal ArrayOperations(AzureCompositeModel client)
/// response payload
/// </summary>
/// <param name='customHeaders'>
/// Headers that will be added to request.
/// Headers that will be added to the request.
/// </param>
/// <param name='cancellationToken'>
/// The cancellation token.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,14 +37,14 @@ public partial class AzureCompositeModel : ServiceClient<AzureCompositeModel>, I
public Uri BaseUri { get; set; }

/// <summary>
/// Gets or sets json serialization settings.
/// Gets the JSON serialization settings.
/// </summary>
public JsonSerializerSettings SerializationSettings { get; private set; }

/// <summary>
/// Gets or sets json deserialization settings.
/// Gets the JSON deserialization settings.
/// </summary>
public JsonSerializerSettings DeserializationSettings { get; private set; }
public JsonSerializerSettings DeserializationSettings { get; private set; }

/// <summary>
/// Gets Azure subscription credentials.
Expand Down Expand Up @@ -117,7 +117,7 @@ public partial class AzureCompositeModel : ServiceClient<AzureCompositeModel>, I
/// Initializes a new instance of the AzureCompositeModel class.
/// </summary>
/// <param name='handlers'>
/// Optional. The delegating handlers to add to the http client pipeline.
/// Optional. The delegating handlers to add to the HTTP pipeline.
/// </param>
protected AzureCompositeModel(params DelegatingHandler[] handlers) : base(handlers)
{
Expand All @@ -128,10 +128,10 @@ protected AzureCompositeModel(params DelegatingHandler[] handlers) : base(handle
/// Initializes a new instance of the AzureCompositeModel class.
/// </summary>
/// <param name='rootHandler'>
/// Optional. The http client handler used to handle http transport.
/// Optional. The HTTP client handler used to handle HTTP transport.
/// </param>
/// <param name='handlers'>
/// Optional. The delegating handlers to add to the http client pipeline.
/// Optional. The delegating handlers to add to the HTTP pipeline.
/// </param>
protected AzureCompositeModel(HttpClientHandler rootHandler, params DelegatingHandler[] handlers) : base(rootHandler, handlers)
{
Expand All @@ -145,7 +145,7 @@ protected AzureCompositeModel(HttpClientHandler rootHandler, params DelegatingHa
/// Optional. The base URI of the service.
/// </param>
/// <param name='handlers'>
/// Optional. The delegating handlers to add to the http client pipeline.
/// Optional. The delegating handlers to add to the HTTP pipeline.
/// </param>
protected AzureCompositeModel(Uri baseUri, params DelegatingHandler[] handlers) : this(handlers)
{
Expand All @@ -163,10 +163,10 @@ protected AzureCompositeModel(Uri baseUri, params DelegatingHandler[] handlers)
/// Optional. The base URI of the service.
/// </param>
/// <param name='rootHandler'>
/// Optional. The http client handler used to handle http transport.
/// Optional. The HTTP client handler used to handle HTTP transport.
/// </param>
/// <param name='handlers'>
/// Optional. The delegating handlers to add to the http client pipeline.
/// Optional. The delegating handlers to add to the HTTP pipeline.
/// </param>
protected AzureCompositeModel(Uri baseUri, HttpClientHandler rootHandler, params DelegatingHandler[] handlers) : this(rootHandler, handlers)
{
Expand All @@ -184,7 +184,7 @@ protected AzureCompositeModel(Uri baseUri, HttpClientHandler rootHandler, params
/// Required. Gets Azure subscription credentials.
/// </param>
/// <param name='handlers'>
/// Optional. The delegating handlers to add to the http client pipeline.
/// Optional. The delegating handlers to add to the HTTP pipeline.
/// </param>
public AzureCompositeModel(ServiceClientCredentials credentials, params DelegatingHandler[] handlers) : this(handlers)
{
Expand All @@ -206,10 +206,10 @@ public AzureCompositeModel(ServiceClientCredentials credentials, params Delegati
/// Required. Gets Azure subscription credentials.
/// </param>
/// <param name='rootHandler'>
/// Optional. The http client handler used to handle http transport.
/// Optional. The HTTP client handler used to handle HTTP transport.
/// </param>
/// <param name='handlers'>
/// Optional. The delegating handlers to add to the http client pipeline.
/// Optional. The delegating handlers to add to the HTTP pipeline.
/// </param>
public AzureCompositeModel(ServiceClientCredentials credentials, HttpClientHandler rootHandler, params DelegatingHandler[] handlers) : this(rootHandler, handlers)
{
Expand All @@ -234,7 +234,7 @@ public AzureCompositeModel(ServiceClientCredentials credentials, HttpClientHandl
/// Required. Gets Azure subscription credentials.
/// </param>
/// <param name='handlers'>
/// Optional. The delegating handlers to add to the http client pipeline.
/// Optional. The delegating handlers to add to the HTTP pipeline.
/// </param>
public AzureCompositeModel(Uri baseUri, ServiceClientCredentials credentials, params DelegatingHandler[] handlers) : this(handlers)
{
Expand Down Expand Up @@ -264,10 +264,10 @@ public AzureCompositeModel(Uri baseUri, ServiceClientCredentials credentials, pa
/// Required. Gets Azure subscription credentials.
/// </param>
/// <param name='rootHandler'>
/// Optional. The http client handler used to handle http transport.
/// Optional. The HTTP client handler used to handle HTTP transport.
/// </param>
/// <param name='handlers'>
/// Optional. The delegating handlers to add to the http client pipeline.
/// Optional. The delegating handlers to add to the HTTP pipeline.
/// </param>
public AzureCompositeModel(Uri baseUri, ServiceClientCredentials credentials, HttpClientHandler rootHandler, params DelegatingHandler[] handlers) : this(rootHandler, handlers)
{
Expand Down Expand Up @@ -345,7 +345,7 @@ private void Initialize()
/// Resource Group ID.
/// </param>
/// <param name='customHeaders'>
/// Headers that will be added to request.
/// Headers that will be added to the request.
/// </param>
/// <param name='cancellationToken'>
/// The cancellation token.
Expand Down Expand Up @@ -514,7 +514,7 @@ private void Initialize()
/// Dictionary of Array of product
/// </param>
/// <param name='customHeaders'>
/// Headers that will be added to request.
/// Headers that will be added to the request.
/// </param>
/// <param name='cancellationToken'>
/// The cancellation token.
Expand Down Expand Up @@ -700,7 +700,7 @@ private void Initialize()
/// Array of dictionary of products
/// </param>
/// <param name='customHeaders'>
/// Headers that will be added to request.
/// Headers that will be added to the request.
/// </param>
/// <param name='cancellationToken'>
/// The cancellation token.
Expand Down
Loading