Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default tag should contains all latest apiVersion swagger file #78

Merged
merged 16 commits into from
Feb 23, 2022

Conversation

ruowan
Copy link
Member

@ruowan ruowan commented Feb 21, 2022

No description provided.

@ruowan ruowan force-pushed the ruowan/default-tag branch from bb582f2 to 65bc079 Compare February 21, 2022 06:05
@ruowan ruowan changed the title Ruowan/default tag Default tag should contains all latest apiVersion swagger file Feb 21, 2022
src/index.ts Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
@ruowan ruowan merged commit 024ebd3 into master Feb 23, 2022
@chgennar
Copy link

chgennar commented Mar 1, 2022

@ruowan - i have the MISSING_APIS_IN_DEFAULT_TAG error showing up in a PR.

image

In my particular case, it looks like a change in casing is causing a discrepancy between an earlier and new version of the same API path. Should this MISSING_APIS_IN_DEFAULT_TAG use a case insensitive comparison? Or possibly should it rely on the operation ids instead of the paths?

@ruowan
Copy link
Member Author

ruowan commented Mar 2, 2022

Thanks for your feedback. This errors use case sensitive comparison for paths and normalize path by ignore parameter. Operation id is more flexible than path.

I think I need to update this rule to use case insensitive comparison.

Could you share the PR link?

@chgennar
Copy link

chgennar commented Mar 2, 2022

Thanks for your feedback. This errors use case sensitive comparison for paths and normalize path by ignore parameter. Operation id is more flexible than path.

I think I need to update this rule to use case insensitive comparison.

Could you share the PR link?

This is the check that is failing on my PR. I think it's caused by a change in casing between two spec versions.
https://github.com/Azure/azure-rest-api-specs/pull/17439/checks?check_run_id=5378743491

@mc3784
Copy link

mc3784 commented Mar 3, 2022

Hi @ruowan
the avocado check on my pr is also failing with this error: MISSING_APIS_IN_DEFAULT_TAG
image

I am not able to understand how to fix it, and would really appreciate some help. Here the link to the PR:
https://github.com/Azure/azure-rest-api-specs-pr/pull/6412/checks?check_run_id=5412195265

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants