Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to OpenOndemand 3.0.1 #1648

Merged
merged 8 commits into from
Aug 2, 2023
Merged

Upgrade to OpenOndemand 3.0.1 #1648

merged 8 commits into from
Aug 2, 2023

Conversation

xpillons
Copy link
Collaborator

@xpillons xpillons commented Jul 21, 2023

  • updated version to 3.0.1
  • remove websockify 0.8.0 and replace by 0.10.0 on CentOS 7.9
  • fix the pinned shell app
  • new file menu initializers to support new syntax
  • update CentOS 79 image with websockify 0.10.0

close #1460

@xpillons xpillons added do-not-merge kind/feature New feature request labels Jul 21, 2023
@xpillons xpillons merged commit ad36696 into main Aug 2, 2023
@xpillons xpillons deleted the feature/ood_3 branch August 2, 2023 07:41
@@ -97,4 +97,4 @@ pun_custom_env:
# See https://osc.github.io/ood-documentation/latest/customization.html#pinning-applications-to-the-dashboard
pinned_apps:
- category: 'Interactive Apps'
- sys/shell/ssh/ondemand
- sys/shell
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xpillons Quick question: Is that a breaking change wrt OOD 2.x?

Are there any other breaking changes that would prevent us from continuing to use az-hop main with OOD 2.x?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't get your point as main is now tight to OOD 3.0. You may have to stay on the 1.0.37 version, as the next one will be pushing OOD 3.x

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well, we have many deployments with previous az-hop versions and may need some of the new features (e.g. naming of VM instances)

Copy link
Contributor

@ltalirz ltalirz Sep 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in any case, if upgrade to OOD3 is smooth and the worker image is out, we can do the upgrade

Copy link
Collaborator Author

@xpillons xpillons Sep 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OOD 3.x works on the already published image, it's the other way we need to confirm

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be super useful to have access to a record of how these marketplace images were created (some git tag of some repository) - in that case we would not have to ask you

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, need to think about it

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

az vm image list --publisher azhpc --offer azhop-desktop --all --output table

@ltalirz yes the other way works. OOD2.x works when using the upcoming updated desktop image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, great!

When you say "upcoming", just to clarify:
Does this mean the currently published desktop image does not yet include the websockify upgrade done below (but still works with OOD 3)?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes this is correct. The existing image does works with OOD 2.x and 3.x. The next image update to be pushed will allow the same.

#yum install -y https://netix.dl.sourceforge.net/project/turbovnc/2.2.5/turbovnc-2.2.5.x86_64.rpm
yum install -y https://yum.osc.edu/ondemand/3.0/compute/el7/x86_64/turbovnc-2.2.5-1.el7.x86_64.rpm
#yum install -y https://cbs.centos.org/kojifiles/packages/python-websockify/0.8.0/13.el7/noarch/python2-websockify-0.8.0-13.el7.noarch.rpm
yum install -y https://yum.osc.edu/ondemand/3.0/compute/el7/x86_64/python3-websockify-0.10.0-1.el7.noarch.rpm
Copy link
Contributor

@ltalirz ltalirz Sep 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xpillons Is there already a marketplace image that includes these changes?
Will they also work with OOD 2.x?

Copy link
Collaborator Author

@xpillons xpillons Sep 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not yet, good point. will test on OOD 2.x. and if the image breaks then you would need to fix the version number in the configuration file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to OOD 3.0.0
2 participants