Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New App Service Rules & Minor Fixes #183

Merged
merged 9 commits into from
Jan 11, 2024
Merged

New App Service Rules & Minor Fixes #183

merged 9 commits into from
Jan 11, 2024

Conversation

cmendible
Copy link
Member

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Unit tests passing

Copy link
Member Author

@cmendible cmendible left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

Attention: 45 lines in your changes are missing coverage. Please review.

Comparison is base (46abc66) 47.49% compared to head (b6e1039) 48.22%.

Files Patch % Lines
internal/scanners/asp/asp.go 0.00% 8 Missing ⚠️
internal/scanners/appcs/appcs.go 0.00% 2 Missing ⚠️
internal/scanners/adf/adf.go 0.00% 1 Missing ⚠️
internal/scanners/afd/afd.go 0.00% 1 Missing ⚠️
internal/scanners/afw/afw.go 0.00% 1 Missing ⚠️
internal/scanners/agw/agw.go 0.00% 1 Missing ⚠️
internal/scanners/aks/aks.go 0.00% 1 Missing ⚠️
internal/scanners/apim/apim.go 0.00% 1 Missing ⚠️
internal/scanners/appi/appi.go 0.00% 1 Missing ⚠️
internal/scanners/ca/ca.go 0.00% 1 Missing ⚠️
... and 27 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #183      +/-   ##
==========================================
+ Coverage   47.49%   48.22%   +0.73%     
==========================================
  Files          72       72              
  Lines        3548     3610      +62     
==========================================
+ Hits         1685     1741      +56     
- Misses       1848     1854       +6     
  Partials       15       15              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cmendible cmendible merged commit 919829d into main Jan 11, 2024
12 checks passed
@cmendible cmendible deleted the chore branch January 11, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants