Add "Did You Mean This" Extension #1692

christopher-o-toole · 2020-05-13T20:10:32Z

Replacing the previous PR #1536

New extension (in preview) which uses the Aladdin service to generate and show failure recovery recommendations on command failure. This extension makes use of the hook added to parser.py in CLI version 2.4.0. For more information, see this CLI PR.

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

…istory/readme info.

…ecommendations aren't available and/or the user has an outdated CLI.

…pathing to recommendation file.

…ookup table logic for now.

…s, add Aladdin style parameter placeholders, remove lookup table references, resolved issue with generated recommendations.

…to extension.

… async update check, clean up integration and unit tests, rely only on pip for versioning.

…. Add some tests to verify normalization.

…gs. Expand command test suite to include a range of commands.

…mmendation model, add base class for aladdin test logic.

… check if telemetry is enabled, add more comments, enable automated test support for user fault command failures and extension metadata, add mock recommendation model file.

…rt_parameters function, remove number of pairs entry from mock recommendation file.

…r static analysis, order imporrts better, remove deprecated parameters from `kusto cluster create` test case, fix global param rules.

…uest module.

azuresdkci · 2020-05-13T20:10:54Z

If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR:

docker run -it microsoft/azure-cli:latest
export EXT=<NAME>
pip install --upgrade --target ~/.azure/cliextensions/$EXT "git+https://github.com/christopher-o-toole/azure-cli-extensions.git@thoth-extension#subdirectory=src/$EXT&egg=$EXT"

…ion.

yonzhan · 2020-05-14T00:44:20Z

add to S170

…emoved unless there are no params.

jiasli

LGTM

src/ai-did-you-mean-this/setup.py

haroldrandom · 2020-05-14T02:20:43Z

/azp run

azure-pipelines · 2020-05-14T02:20:51Z

Azure Pipelines successfully started running 1 pipeline(s).

src/ai-did-you-mean-this/azext_ai_did_you_mean_this/custom.py

…ole/azure-cli-extensions into thoth-extension

Christopher OToole and others added 23 commits April 3, 2020 17:14

Setup extension scaffolding, create dummy version command, add help/h…

8305ee4

…istory/readme info.

Add v0 recommendation file. Handle general extension logic for when r…

c29b090

…ecommendations aren't available and/or the user has an outdated CLI.

Fix empty iterable check, add guard against extension usage.

ce8e6de

Disable linter warning for CLIError import, add more robust relative …

2476efd

…pathing to recommendation file.

Add lookup table. Adjust minimum CLI version. Comment out parameter l…

3cb8aac

…ookup table logic for now.

Move "not able to help" message to function, accept list of parameter…

e7916b0

…s, add Aladdin style parameter placeholders, remove lookup table references, resolved issue with generated recommendations.

Fix typo in comment.

89ccf9c

Remove comment.

3871f0a

Clean up extension logic, adjust style based on flake8 and pylint.

0aaa994

Integration tests, async/sync cli version check, integrate service in…

f708094

…to extension.

Don't capture NumberOfPairs, register command table callback, disable…

f6b5d69

… async update check, clean up integration and unit tests, rely only on pip for versioning.

Normalize parameters and remove invalid command tokens where possible…

9bf6db3

…. Add some tests to verify normalization.

Update tests to reflect current recommendation model. Update recordin…

408a261

…gs. Expand command test suite to include a range of commands.

Switch to mock aladdin service call data, rename files, add mock reco…

d0f65c0

…mmendation model, add base class for aladdin test logic.

Add copyright notice to all files, update minCliCoreVersion to 2.4.0,…

6fc9cd4

… check if telemetry is enabled, add more comments, enable automated test support for user fault command failures and extension metadata, add mock recommendation model file.

Assert that the correct command is returned from the normalize_and_so…

ab8dfa3

…rt_parameters function, remove number of pairs entry from mock recommendation file.

Add additional comments/clarification.

28d0140

Drop Python 2 support from setup.cfg

edd4f86

Merge branch 'master' into thoth-extension

55aa449

Update to use standard library mock, disable colorama import error fo…

bee938b

…r static analysis, order imporrts better, remove deprecated parameters from `kusto cluster create` test case, fix global param rules.

Make extension test more generic.

9005692

Patch the correct setup.cfg file.

cf00711

Remove sensitive file, merge command group, handle exception from req…

162a2ef

…uest module.

Christopher OToole added 5 commits May 13, 2020 14:05

Handle case in which the correlation ID or subscription ID is not set.

955a1fc

Don't use get_subscription_id.

0a3eb00

Remove erroneous import.

1c806ad

Remove another erroneous import.

d0819db

Add instructions for trying out an experimental release of the extens…

c1eb46b

…ion.

yonzhan requested a review from fengzhou-msft May 14, 2020 00:43

yonzhan requested a review from jiasli May 14, 2020 00:44

yonzhan assigned fengzhou-msft May 14, 2020

yonzhan requested a review from haroldrandom May 14, 2020 00:44

yonzhan added this to the S170 milestone May 14, 2020

Christopher OToole added 4 commits May 13, 2020 17:55

Added a detailed README, fixed bug in which invalid tokens were not r…

144ff52

…emoved unless there are no params.

Merge remote-tracking branch 'origin/master' into thoth-extension

e4b790c

Add final newline to _const.py

9982777

Make styling check obey coloring configuration in core.

665e3fd

jiasli approved these changes May 14, 2020

View reviewed changes

haroldrandom reviewed May 14, 2020

View reviewed changes

src/ai-did-you-mean-this/setup.py Outdated Show resolved Hide resolved

haroldrandom reviewed May 14, 2020

View reviewed changes

src/ai-did-you-mean-this/setup.py Outdated Show resolved Hide resolved

haroldrandom approved these changes May 14, 2020

View reviewed changes

Jianhui Harold added 2 commits May 14, 2020 10:21

Update src/ai-did-you-mean-this/setup.py

79ee91b

Update src/ai-did-you-mean-this/setup.py

1569869

fengzhou-msft approved these changes May 14, 2020

View reviewed changes

fengzhou-msft reviewed May 14, 2020

View reviewed changes

src/ai-did-you-mean-this/azext_ai_did_you_mean_this/custom.py Outdated Show resolved Hide resolved

Christopher OToole added 2 commits May 14, 2020 11:01

Changed variable name to avoid chromium issue 981129.

f28c256

Merge branch 'thoth-extension' of https://github.com/christopher-o-to…

d9ea28e

…ole/azure-cli-extensions into thoth-extension

fengzhou-msft approved these changes May 15, 2020

View reviewed changes

fengzhou-msft merged commit 87cbfa1 into Azure:master May 15, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add "Did You Mean This" Extension #1692

Add "Did You Mean This" Extension #1692

christopher-o-toole commented May 13, 2020 •

edited by jiasli

Loading

azuresdkci commented May 13, 2020

yonzhan commented May 14, 2020

jiasli left a comment

haroldrandom commented May 14, 2020

azure-pipelines bot commented May 14, 2020

Add "Did You Mean This" Extension #1692

Add "Did You Mean This" Extension #1692

Conversation

christopher-o-toole commented May 13, 2020 • edited by jiasli Loading

General Guidelines

About Extension Publish

azuresdkci commented May 13, 2020

yonzhan commented May 14, 2020

jiasli left a comment

Choose a reason for hiding this comment

haroldrandom commented May 14, 2020

azure-pipelines bot commented May 14, 2020

christopher-o-toole commented May 13, 2020 •

edited by jiasli

Loading