Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Firewall]az network firewall create: Add new parameter --tier #3250

Merged
merged 8 commits into from
May 21, 2021

Conversation

msyyc
Copy link
Member

@msyyc msyyc commented Apr 12, 2021


RE: Firewall Premium changes - Azure CLI

This checklist is used to make sure that common guidelines for a pull request are followed.

need to fix test :

test_azure_firewall_management_ip_config
test_azure_firewall_virtual_hub

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

@msyyc msyyc requested a review from kairu-ms as a code owner April 12, 2021 06:06
@msyyc msyyc self-assigned this Apr 12, 2021
@msyyc msyyc changed the title [Firewall] az network firewall create: Add new parameter --tier [Firewall]az network firewall create: Add new parameter --tier Apr 12, 2021
@yonzhan
Copy link
Collaborator

yonzhan commented Apr 12, 2021

Firewall

@yonzhan yonzhan requested a review from jsntcy April 12, 2021 06:20
@yonzhan yonzhan added this to the S186 milestone Apr 12, 2021
@yonzhan yonzhan modified the milestones: S186, S187 May 21, 2021
@msyyc msyyc merged commit 39d2d9b into Azure:master May 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants