Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aks): check parent scopes role assignments in pod identity assignment #3889

Merged
merged 1 commit into from
Sep 15, 2021
Merged

fix(aks): check parent scopes role assignments in pod identity assignment #3889

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions src/aks-preview/azext_aks_preview/custom.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4184,15 +4184,25 @@ def _ensure_managed_identity_operator_permission(cli_ctx, instance, scope):

factory = get_auth_management_client(cli_ctx, scope)
assignments_client = factory.role_assignments
cluster_identity_object_id = cluster_identity_object_id.lower()
scope = scope.lower()

for i in assignments_client.list_for_scope(scope=scope, filter='atScope()'):
if i.scope.lower() != scope.lower():
continue
# list all assignments of the target identity (scope) that assigned to the cluster identity
filter_query = "atScope() and assignedTo('{}')".format(cluster_identity_object_id)
for i in assignments_client.list_for_scope(scope=scope, filter=filter_query):
if not i.role_definition_id.lower().endswith(CONST_MANAGED_IDENTITY_OPERATOR_ROLE_ID):
continue
if i.principal_id.lower() != cluster_identity_object_id.lower():

# sanity checks to make sure we see the correct assignments
if i.principal_id.lower() != cluster_identity_object_id:
# assignedTo() should return the assignment to cluster identity
continue
if not scope.startswith(i.scope.lower()):
# atScope() should return the assignments in subscription / resource group / resource level
continue

# already assigned
logger.debug('Managed Identity Opereator role has been assigned to {}'.format(i.scope))
return

if not _add_role_assignment(cli_ctx, CONST_MANAGED_IDENTITY_OPERATOR_ROLE, cluster_identity_object_id,
Expand Down