[k8s-configuration] Release v1.2.0 with Flux v2 Support #4100

jonathan-innis · 2021-11-12T06:44:43Z

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

[pull] release from Azure:master

…into k8s-configuration

…into k8s-extension/public-preview

* Update models to track2 * Increase k8s-configuration version number * Update kind version * Change error to warning because of DSA failure

…into k8s-configuration

* Scaffold out the k8s-config package * Base implementation of CLI commands * Add create scenario and cleanup in consts * Add help text to commands, params * Add other clients to client factory * Automatically installing the flux extension * Move flux and extension into modules * Updated the versioned sdks * Push working command for testing * Update to multi api versioned sdk * Support other extension methods * Fix nullity check * Add source control provider * Add scc commands * Add defer logic for create with cache * Use default extension with identity * Fix identity creation * Add kustomization caching * Add formatters * Add scc provider * Add help text for k8s-config fluxv1 * Add help text for extension * Allow force delete of extension and fluxconfiguration * Add location to the extension model * Update with latest from k8s-extension * Add k8s-config testing * Add license header * Fix all style issues * Update codeowners file * Validate data before checking cluster compliance * No kustomizations warning * Fix identity issue in 2020-07-01 * Fix k8s regex * Fix configuration name regex validation * Fix name length validation * Adding some validation warnings * Add protected settings to request * Exclude private test path * Add suspend functionality * Add correct values to build Kustomization * Add no_wait * Fix style issues * Use base64 encoded httpsUser * Fix formatting error and base64 encoding error * Fix style issues * Fix force * Updated help text * Style fixes * Increase namespace maximum len * Add managed cluster support to k8s-config * Custom confirmation when prune is enabled * Add flux commands to existing k8s-configuration * Remove extension provider from CLI * Fix style issues * Override extension variables * Strip newlines from known_hosts file * Update help text and validators * Strip newlines from known hosts * Add provisioning state check for flux extension * Pin helm version * Remove validation from create command * Add patch support with new SDK * Add implementation for CRUD of source and kustomization * Fix errors on patch * Fix some bugs in patching properties * Add fixes for patch in k8s-configuraiton * Change duration formatting in table output * Add validation and conversion for durations * Bump verison and fix typo * Fix bug with dependencies * Fix linter and style issues * Fix delete prune check * Add flux testing * Create separate jobs for scenarios * Update error text

…into k8s-configuration

yonzhan · 2021-11-12T08:44:28Z

k8s-configuration

zhoxing-ms · 2021-11-15T06:19:32Z

src/dataprotection/azext_dataprotection/manual/version.py

-# --------------------------------------------------------------------------
-# Copyright (c) Microsoft Corporation. All rights reserved.
-# Licensed under the MIT License. See License.txt in the project root for
-# license information.
-#
-# Code generated by Microsoft (R) AutoRest Code Generator.
-# Changes may cause incorrect behavior and will be lost if the code is
-# regenerated.
-# --------------------------------------------------------------------------
-
-VERSION = "0.2.0"
+# --------------------------------------------------------------------------
+# Copyright (c) Microsoft Corporation. All rights reserved.
+# Licensed under the MIT License. See License.txt in the project root for
+# license information.
+#
+# Code generated by Microsoft (R) AutoRest Code Generator.
+# Changes may cause incorrect behavior and will be lost if the code is
+# regenerated.
+# --------------------------------------------------------------------------
+
+VERSION = "0.2.0"


Why do we need to modify this file?

src/k8s-configuration/azext_k8s_configuration/_params.py

zhoxing-ms · 2021-11-15T06:26:29Z

src/k8s-configuration/azext_k8s_configuration/_params.py

+                   help='Base64-encoded HTTPS CA certificate for TLS communication with private repository sync')
+        c.argument('https_ca_cert_file',
+                   arg_group="Auth",
+                   help='Filepath to HTTPS CA certificate file for TLS communication with private repository sync')


Suggested change

help='Filepath to HTTPS CA certificate file for TLS communication with private repository sync')

help='File path to HTTPS CA certificate file for TLS communication with private repository sync')

zhoxing-ms · 2021-11-15T06:26:45Z

src/k8s-configuration/azext_k8s_configuration/_params.py

+                   help='Base64-encoded known_hosts data containing public SSH keys required to access private Git instances')
+        c.argument('known_hosts_file',
+                   arg_group="Auth",
+                   help='Filepath to known_hosts contents containing public SSH keys required to access private Git instances')


Suggested change

help='Filepath to known_hosts contents containing public SSH keys required to access private Git instances')

help='File path to known hosts contents containing public SSH keys required to access private Git instances')

zhoxing-ms · 2021-11-15T06:28:54Z

src/k8s-configuration/azext_k8s_configuration/commands.py

+        g.custom_command('update', 'flux_config_update', supports_no_wait=True)
+        g.custom_command('list', "flux_config_list", table_transformer=fluxconfig_list_table_format)
+        g.custom_show_command('show', 'flux_config_show', table_transformer=fluxconfig_show_table_format)
+        g.custom_command('delete', 'flux_config_delete', supports_no_wait=True)


Do we need to consider adding confirmation=True for the delete operation

We are using custom delete confirmation, so we are not using the default confirmation as provided by the CLI

https://github.com/AzureArcForKubernetes/azure-cli-extensions/blob/k8s-configuration-release-1.2.0/src/k8s-configuration/azext_k8s_configuration/providers/FluxConfigurationProvider.py#L341

Got it, thanks~

zhoxing-ms · 2021-11-15T06:29:05Z

src/k8s-configuration/azext_k8s_configuration/commands.py

+    with self.command_group('k8s-configuration flux kustomization', k8s_configuration_fluxconfig_sdk, client_factory=k8s_configuration_fluxconfig_client, is_preview=True) as g:
+        g.custom_command('create', 'flux_config_create_kustomization', supports_no_wait=True)
+        g.custom_command('update', 'flux_config_update_kustomization', supports_no_wait=True)
+        g.custom_command('delete', 'flux_config_delete_kustomization', supports_no_wait=True)


Same as above

Same comment as above, we are using custom confirmation

jonathan-innis and others added 30 commits March 10, 2021 13:25

Create pull.yml

828f9d3

Update pull.yml

1436bfc

Update azure-pipelines.yml

6cffd96

Initial commit of k8s-extension

db0f4bd

Update CODEOWNERS

4293a80

Update azure-pipelines.yml

1b39860

Create pull.yml

eba804c

Update pull.yml

acc9c7e

Update pull.yml

6507446

Update pipelines file

a0761d9

Update k8s-configuration name

4c4ea52

Update test script params

007e0d3

Update pipeline file

f461b7f

Remove codeowners

556f545

Update pipelines file

3e2ea64

Update CODEOWNERS

9bbc0e4

Update private preview pipelines

8d46cbc

Remove open service mesh from public release

6c3ba41

Merge pull request #6 from Azure/master

a98e996

[pull] release from Azure:master

Update pipeline files

43c6796

Update custom pipelines files

c88876f

Add publish step to k8s-configuration

ea8aa7d

Update pipeline to publish extension

f9874d6

Update public extension pipeline

009a83e

Change condition variable

8e058c5

Update pipeline naming

664009c

Add version to public preview/private preview

dea40c1

Merge branch 'master' of https://github.com/Azure/azure-cli-extensions …

f56d86a

…into k8s-configuration

Merge branch 'master' of https://github.com/Azure/azure-cli-extensions …

69269e0

…into k8s-extension/public-preview

Update pipelines

e81e010

jonathan-innis added 13 commits July 20, 2021 13:13

Update k8s-configuration Models to Track2 (#63)

fd97374

* Update models to track2 * Increase k8s-configuration version number * Update kind version * Change error to warning because of DSA failure

Merge branch 'Azure:main' into k8s-configuration

e3c3e7a

Merge branch 'main' of https://github.com/Azure/azure-cli-extensions …

6b2f7dc

…into k8s-configuration

Upgrade helm operator chart version (#75)

3b5c2eb

Merge branch 'main' of https://github.com/Azure/azure-cli-extensions …

dd1d1fb

…into k8s-configuration

Merge branch 'main' of https://github.com/Azure/azure-cli-extensions …

37bb7c0

…into k8s-configuration

Pin helm version

e542474

Bump version

65d9554

Migrate pipeline (#90)

8f622c6

Disable updates on configuration tests (#89)

d011762

Merge branch 'main' of https://github.com/Azure/azure-cli-extensions …

77d9b19

…into k8s-configuration

Remove unneeded files

0866167

yonzhan requested review from zhoxing-ms and wangzelin007 November 12, 2021 08:44

yonzhan assigned zhoxing-ms Nov 12, 2021

yonzhan added this to the Nov 2021 (2021-12-07) milestone Nov 12, 2021

zhoxing-ms reviewed Nov 15, 2021

View reviewed changes

src/k8s-configuration/azext_k8s_configuration/_params.py Show resolved Hide resolved

zhoxing-ms reviewed Nov 15, 2021

View reviewed changes

jonathan-innis added 2 commits November 15, 2021 10:08

Fix filepath suggestion from CLI team

68a7458

Fix unneeded file edit

65a3927

jonathan-innis force-pushed the k8s-configuration-release-1.2.0 branch from 2f6d82b to 65a3927 Compare November 15, 2021 18:12

jonathan-innis requested a review from zhoxing-ms November 15, 2021 18:14

zhoxing-ms approved these changes Nov 16, 2021

View reviewed changes

zhoxing-ms merged commit a9ec99d into Azure:main Nov 16, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[k8s-configuration] Release v1.2.0 with Flux v2 Support #4100

[k8s-configuration] Release v1.2.0 with Flux v2 Support #4100

jonathan-innis commented Nov 12, 2021 •

edited

Loading

yonzhan commented Nov 12, 2021

zhoxing-ms Nov 15, 2021

zhoxing-ms Nov 15, 2021

zhoxing-ms Nov 15, 2021 •

edited

Loading

zhoxing-ms Nov 15, 2021

jonathan-innis Nov 15, 2021

zhoxing-ms Nov 16, 2021

zhoxing-ms Nov 15, 2021

jonathan-innis Nov 15, 2021

	help='Filepath to HTTPS CA certificate file for TLS communication with private repository sync')
	help='File path to HTTPS CA certificate file for TLS communication with private repository sync')

	help='Filepath to known_hosts contents containing public SSH keys required to access private Git instances')
	help='File path to known hosts contents containing public SSH keys required to access private Git instances')

[k8s-configuration] Release v1.2.0 with Flux v2 Support #4100

[k8s-configuration] Release v1.2.0 with Flux v2 Support #4100

Conversation

jonathan-innis commented Nov 12, 2021 • edited Loading

General Guidelines

About Extension Publish

yonzhan commented Nov 12, 2021

zhoxing-ms Nov 15, 2021

Choose a reason for hiding this comment

zhoxing-ms Nov 15, 2021

Choose a reason for hiding this comment

zhoxing-ms Nov 15, 2021 • edited Loading

Choose a reason for hiding this comment

zhoxing-ms Nov 15, 2021

Choose a reason for hiding this comment

jonathan-innis Nov 15, 2021

Choose a reason for hiding this comment

zhoxing-ms Nov 16, 2021

Choose a reason for hiding this comment

zhoxing-ms Nov 15, 2021

Choose a reason for hiding this comment

jonathan-innis Nov 15, 2021

Choose a reason for hiding this comment

jonathan-innis commented Nov 12, 2021 •

edited

Loading

zhoxing-ms Nov 15, 2021 •

edited

Loading