Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{AKS} Update readme to add dependency description #5212

Merged
merged 6 commits into from
Aug 15, 2022

Conversation

FumingZhang
Copy link
Member


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify src/index.json.

@ghost ghost requested review from zhoxing-ms and wangzelin007 August 8, 2022 03:05
@ghost ghost assigned zhoxing-ms Aug 8, 2022
@ghost ghost added this to the Aug 2022 (2022-09-06) milestone Aug 8, 2022
@ghost ghost added the Auto-Assign Auto assign by bot label Aug 8, 2022
@ghost ghost requested a review from yonzhan August 8, 2022 03:05
@ghost ghost added the AKS label Aug 8, 2022
@yonzhan
Copy link
Collaborator

yonzhan commented Aug 8, 2022

AKS

@FumingZhang FumingZhang marked this pull request as ready for review August 8, 2022 04:58
@@ -7,7 +7,7 @@ Guidance
++++++++
If there is no rush to release a new version, please just add a description of the modification under the *Pending* section.

To release a new version, please select a new version number (usually plus 1 to the minor of the current latest version number), and then add a new section named as the new version number in this file, the content should include the new modifications and everything from the *Pending* section. Finally, update the `VERSION` in `setup.py` with this new version number.
To release a new version, please select a new version number (usually plus 1 to last patch version, X.Y.Z (Major.Minor.Patch)), and then add a new section named as the new version number in this file, the content should include the new modifications and everything from the *Pending* section. Finally, update the `VERSION` variable in `setup.py` with this new version number.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use this document to explain Semantic Versioning?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, added link to doc.

@FumingZhang FumingZhang force-pushed the fuming/add-dependency-0808 branch from 4bc8965 to 2abd2b6 Compare August 10, 2022 02:39
@FumingZhang FumingZhang marked this pull request as draft August 10, 2022 05:24
@FumingZhang FumingZhang marked this pull request as ready for review August 11, 2022 10:38
@zhoxing-ms zhoxing-ms merged commit ae5596f into Azure:main Aug 15, 2022
@FumingZhang FumingZhang deleted the fuming/add-dependency-0808 branch August 22, 2022 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AKS Auto-Assign Auto assign by bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants