-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{AKS} Update readme to add dependency description #5212
Merged
zhoxing-ms
merged 6 commits into
Azure:main
from
FumingZhang:fuming/add-dependency-0808
Aug 15, 2022
Merged
{AKS} Update readme to add dependency description #5212
zhoxing-ms
merged 6 commits into
Azure:main
from
FumingZhang:fuming/add-dependency-0808
Aug 15, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned zhoxing-ms
Aug 8, 2022
ghost
added this to the Aug 2022 (2022-09-06) milestone
Aug 8, 2022
ghost
requested a review
from yonzhan
August 8, 2022 03:05
ghost
added
the
AKS
label
Aug 8, 2022
AKS |
wangzelin007
reviewed
Aug 8, 2022
src/aks-preview/HISTORY.rst
Outdated
@@ -7,7 +7,7 @@ Guidance | |||
++++++++ | |||
If there is no rush to release a new version, please just add a description of the modification under the *Pending* section. | |||
|
|||
To release a new version, please select a new version number (usually plus 1 to the minor of the current latest version number), and then add a new section named as the new version number in this file, the content should include the new modifications and everything from the *Pending* section. Finally, update the `VERSION` in `setup.py` with this new version number. | |||
To release a new version, please select a new version number (usually plus 1 to last patch version, X.Y.Z (Major.Minor.Patch)), and then add a new section named as the new version number in this file, the content should include the new modifications and everything from the *Pending* section. Finally, update the `VERSION` variable in `setup.py` with this new version number. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use this document to explain Semantic Versioning?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, added link to doc.
wangzelin007
approved these changes
Aug 9, 2022
FumingZhang
force-pushed
the
fuming/add-dependency-0808
branch
from
August 10, 2022 02:39
4bc8965
to
2abd2b6
Compare
zhoxing-ms
approved these changes
Aug 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>
locally? (pip install azdev
required)python scripts/ci/test_index.py -q
locally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.json
automatically.The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify
src/index.json
.