-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{CI} Fix #5408: Miss a __init__.py
file in src/reservation/azext_reservation/vendored_sdks
directory
#5421
Conversation
__init__.py
file in src/reservation/azext_reservation/vendored_sdks
directory
__init__.py
file in src/reservation/azext_reservation/vendored_sdks
directory__init__.py
file in src/reservation/azext_reservation/vendored_sdks
directory
__init__.py
file in src/reservation/azext_reservation/vendored_sdks
directory__init__.py
file in src/reservation/azext_reservation/vendored_sdks
directory
# regenerated. | ||
# -------------------------------------------------------------------------- | ||
|
||
__path__ = __import__('pkgutil').extend_path(__path__, __name__) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps an empty __init__.py
will work? Since this vendored_sdks
doesn't need to be a namespace package.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I copied this file from another extension just to be safe.
There is no problem with using an empty __init__.py
file.
Really good catch! |
[Release] Update index.json for extension [ reservation ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=7493&view=results |
The pull request #5408 miss a
__init__.py
file insrc/reservation/azext_reservation/vendored_sdks
directory.So the vendored_sdks directory will not include when buliding wheel package.
That will cause azure-cli pipeline error:
and azure-cli-extension pipeline error:
Test screenshot:
before change
after change