Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove containerapp compose #5430

Merged
merged 2 commits into from
Oct 11, 2022
Merged

Remove containerapp compose #5430

merged 2 commits into from
Oct 11, 2022

Conversation

StrawnSC
Copy link
Contributor

@StrawnSC StrawnSC commented Oct 8, 2022

The command for this will be migrated to the containerapp extension: see #5426


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify src/index.json.

@ghost ghost requested a review from yonzhan October 8, 2022 00:46
@ghost ghost added the Auto-Assign Auto assign by bot label Oct 8, 2022
@ghost ghost requested a review from wangzelin007 October 8, 2022 00:46
@ghost ghost assigned zhoxing-ms Oct 8, 2022
@ghost ghost added this to the Oct 2022 (2022-11-01) milestone Oct 8, 2022
@ghost ghost added the ContainerApp label Oct 8, 2022
@yonzhan
Copy link
Collaborator

yonzhan commented Oct 8, 2022

Remove containerapp compose

@smurawski
Copy link
Contributor

@StrawnSC I think you'll need to clean up the CredScanSuppressions.json file too.

@StrawnSC
Copy link
Contributor Author

@StrawnSC I think you'll need to clean up the CredScanSuppressions.json file too.

Thanks, just removed those as well

Copy link
Contributor

@smurawski smurawski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm glad to see this functionality moving to the containerapp extension!

Thanks @StrawnSC !

@zhoxing-ms
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wangzelin007 wangzelin007 reopened this Oct 11, 2022
@zhoxing-ms zhoxing-ms merged commit 37498df into Azure:main Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Assign Auto assign by bot ContainerApp
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants