[AKS] Add --disable-windows-outbound-nat for az aks nodepool add to add a Windows agent pool which the Windows OutboundNAT is disabled
#5456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…indows agent pool which the Windows OutboundNAT is disabled
ShiqianTao
requested review from
andyliuliming and
FumingZhang
as code owners
ghost
requested review from
ghost
assigned 
|
Hi @FumingZhang @AbelHu , could you help to review this PR? Thank you. |
FumingZhang
reviewed
Oct 17, 2022
| def validate_disable_windows_outbound_nat(namespace): | ||
| """Validates disable_windows_outbound_nat can only be used on Windows.""" | ||
| if namespace.disable_windows_outbound_nat: | ||
| if hasattr(namespace, 'os_type') and namespace.os_type != "Windows": |
There was a problem hiding this comment.
Should handle case-insensitive comparation?
There was a problem hiding this comment.
Improved. Thank you.
| @@ -328,6 +372,8 @@ def construct_agentpool_profile_preview(self) -> AgentPool: | |||
| agentpool = self.set_up_gpu_properties(agentpool) | |||
| # set up custom ca trust | |||
| agentpool = self.set_up_custom_ca_trust(agentpool) | |||
| # set up custom ca trust | |||
There was a problem hiding this comment.
Updated. Thank you.
AbelHu
reviewed
Oct 17, 2022
|
Queued a pipeline to test the newly added case. Passed. |
AbelHu
approved these changes
Oct 17, 2022
|
Hi @zhoxing-ms , cloud you help to review and approve this PR? Thank you. |
|
@zhoxing-ms for awareness |
zhoxing-ms
approved these changes
Oct 17, 2022
|
[Release] Update index.json for extension [ aks-preview ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=9171&view=results |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[AKS] Add
--disable-windows-outbound-natforaz aks nodepool addto add a Windows agent pool which the Windows OutboundNAT is disabledThis checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify
src/index.json.