Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update API version for az network-function traffic-collector #5461

Merged
merged 1 commit into from
Oct 18, 2022

Conversation

rmodh
Copy link
Contributor

@rmodh rmodh commented Oct 17, 2022


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify src/index.json.

@ghost ghost added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label Oct 17, 2022
@ghost
Copy link

ghost commented Oct 17, 2022

Thank you for your contribution rmodh! We will review the pull request and get back to you soon.

@ghost ghost requested review from yonzhan, jsntcy and kairu-ms October 17, 2022 17:28
@ghost ghost added the Auto-Assign Auto assign by bot label Oct 17, 2022
@ghost ghost requested review from wangzelin007 and necusjz October 17, 2022 17:28
@ghost ghost assigned necusjz Oct 17, 2022
@ghost ghost added this to the Oct 2022 (2022-11-01) milestone Oct 17, 2022
@ghost ghost added the Network label Oct 17, 2022
@yonzhan
Copy link
Collaborator

yonzhan commented Oct 17, 2022

traffic-collector

Copy link
Contributor

@kairu-ms kairu-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for the change. Please update version and release history file as well if you want to release.

@kairu-ms kairu-ms merged commit 36f80f3 into Azure:main Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Assign Auto assign by bot customer-reported Issues that are reported by GitHub users external to the Azure organization. Network
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants