Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

containerapp: fix create or update containerapp --yaml exposedPort #6074

Conversation

Greedygre
Copy link
Contributor


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az containerapp env update
az containerapp create/update --yaml

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify src/index.json.

@azure-client-tools-bot-prd
Copy link

Hi @Greedygre,
Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

@ghost ghost requested a review from yonzhan March 27, 2023 07:01
@ghost ghost added the Auto-Assign Auto assign by bot label Mar 27, 2023
@ghost ghost requested review from wangzelin007 and yanzhudd March 27, 2023 07:01
@ghost ghost assigned zhoxing-ms Mar 27, 2023
@ghost ghost added the ContainerApp label Mar 27, 2023
@ghost ghost requested review from zhoxing-ms and jsntcy March 27, 2023 07:01
@yonzhan
Copy link
Collaborator

yonzhan commented Mar 27, 2023

containerapp

@zhoxing-ms
Copy link
Contributor

Please write the description of this PR change into HISTORY.rst. And if you want to release a new extension version for this PR, please also upgrade the version defined in the setup.py.

@Greedygre
Copy link
Contributor Author

@zhoxing-ms
Hi, this PR has been reviewed by hong and zunli, and it needs to be merged before #6081
please help to review and merge, thanks!

@zhoxing-ms zhoxing-ms merged commit ceab341 into Azure:main Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Assign Auto assign by bot ContainerApp
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants