-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[vm-repair] arm64 support And Bug Fix for telemetry #6649
Conversation
vm-repair |
️✔️Azure CLI Extensions Breaking Change Test
|
Could you add some test cases for this PR change? |
Please add more details (related commands and parameters) to the description. |
@zhoxing-ms added a test case. |
CI check failure seems unrelated to my changes. |
[Release] Update index.json for extension [ vm-repair ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=87539&view=results |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The object/property command.message is populated with information about the fstab action which got executed. This looks to be like a generic message which may confuse people if a different action is used. Is there a condition I overlooked which is responsible for getting the message generated?
This PR contains:
ARM64 VM's support for vm repair creation
Telemetry Fix for repair-and-restore command
Repair VM fix for gen1 VM attaching disk on SCSI controller, preventing nested VM from booting (by Ryan McCallum)
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az vm repair create -g {rg} -n {vm}
General Guidelines
azdev style <YOUR_EXT>
locally? (pip install azdev
required)python scripts/ci/test_index.py -q
locally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.json
automatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json
.