Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vm-repair] arm64 support And Bug Fix for telemetry #6649

Merged
merged 6 commits into from
Sep 1, 2023

Conversation

haagha
Copy link
Member

@haagha haagha commented Aug 15, 2023

This PR contains:

ARM64 VM's support for vm repair creation
Telemetry Fix for repair-and-restore command
Repair VM fix for gen1 VM attaching disk on SCSI controller, preventing nested VM from booting (by Ryan McCallum)


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az vm repair create -g {rg} -n {vm}

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@yonzhan
Copy link
Collaborator

yonzhan commented Aug 15, 2023

vm-repair

@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Aug 15, 2023

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@haagha haagha changed the title [vm-repair] arm64 support [vm-repair] arm64 support And Bug Fix for telemetry Aug 21, 2023
@zhoxing-ms
Copy link
Contributor

Could you add some test cases for this PR change?

@yanzhudd
Copy link
Contributor

Please add more details (related commands and parameters) to the description.

@haagha
Copy link
Member Author

haagha commented Sep 1, 2023

@zhoxing-ms added a test case.

@haagha
Copy link
Member Author

haagha commented Sep 1, 2023

CI check failure seems unrelated to my changes.

@zhoxing-ms zhoxing-ms merged commit 99f1152 into Azure:main Sep 1, 2023
@azclibot
Copy link
Collaborator

azclibot commented Sep 1, 2023

[Release] Update index.json for extension [ vm-repair ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=87539&view=results

Copy link
Member

@malachma malachma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The object/property command.message is populated with information about the fstab action which got executed. This looks to be like a generic message which may confuse people if a different action is used. Is there a condition I overlooked which is responsible for getting the message generated?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Assign Auto assign by bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants