Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[connectedvmware] Bug fix for get-resource-id #6686

Merged
merged 1 commit into from
Aug 24, 2023

Conversation

nascarsayan
Copy link
Contributor

@nascarsayan nascarsayan commented Aug 24, 2023

There was a bug that was introduced in 0.2.0. The resource-group override was not getting honoured.
We are honouring it now.


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@nascarsayan nascarsayan changed the title Bug fix for get-resource-id [connectedvmware] Bug fix for get-resource-id Aug 24, 2023
@yonzhan
Copy link
Collaborator

yonzhan commented Aug 24, 2023

Thank you for your contribution! We will review the pull request and get back to you soon.

@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Aug 24, 2023

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@kairu-ms kairu-ms merged commit 2e35303 into Azure:main Aug 24, 2023
@nascarsayan nascarsayan deleted the dev/snaskar/vmware-fixes branch August 24, 2023 09:13
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ connectedvmware ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=85630&view=results

bgashirabake pushed a commit to bgashirabake/azure-cli-extensions that referenced this pull request Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants