Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add list-usages command for container app #6691

Merged
merged 2 commits into from
Aug 25, 2023

Conversation

Juliehzl
Copy link
Contributor


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Aug 25, 2023

⚠️Azure CLI Extensions Breaking Change Test
⚠️containerapp
rule cmd_name rule_message suggest_message
⚠️ 1001 - CmdAdd containerapp env list-usages cmd containerapp env list-usages added
⚠️ 1001 - CmdAdd containerapp list-usages cmd containerapp list-usages added

@azure-client-tools-bot-prd
Copy link

Hi @Juliehzl,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Aug 25, 2023

Thank you for your contribution! We will review the pull request and get back to you soon.

@@ -49,7 +49,7 @@
ContainerAppsJobClient,
ContainerAppPreviewClient,
AuthPreviewClient,
SubscriptionPreviewClient
SubscriptionPreviewClient, ManagedEnvironmentPreviewClient
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
SubscriptionPreviewClient, ManagedEnvironmentPreviewClient
SubscriptionPreviewClient,
ManagedEnvironmentPreviewClient

@zhoxing-ms zhoxing-ms merged commit 66160bc into Azure:main Aug 25, 2023
bgashirabake pushed a commit to bgashirabake/azure-cli-extensions that referenced this pull request Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Assign Auto assign by bot ContainerApp
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants