{containerapp} raise ValidationError when value in --yaml is None #6693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️Azure CLI Extensions Breaking Change Test
|
|
Hi @Greedygre, |
microsoft-github-policy-service
bot
requested review from
yonzhan,
wangzelin007 and
yanzhudd
|
containerapp |
microsoft-github-policy-service
bot
requested review from
zhoxing-ms,
jsntcy,
ruslany,
sanchitmehta,
ebencarek,
JennyLawrance,
howang-ms,
vinisoto,
chinadragon0515,
vturecek,
torosent,
pagariyaalok,
Juliehzl and
jijohn14
Juliehzl
reviewed
Aug 28, 2023
Greedygre
force-pushed
the
xinyu/fix_yaml_none
branch
from
9554b27 to
f005567
Compare
Juliehzl
approved these changes
Aug 28, 2023
|
Hi @zhoxing-ms |
zhoxing-ms
approved these changes
Aug 28, 2023
bgashirabake
pushed a commit
to bgashirabake/azure-cli-extensions
that referenced
this pull request
Aug 30, 2023
…ure#6693) * raise ValidationError when value in --yaml is None * add test * raise ValidationError when value in --yaml is None * add test * remove usused code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az containerapp create/update
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.