-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add spring cloud gateway cli #8037
Merged
Merged
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
cf29687
spring cloud gateway cli
5e50736
Merge remote-tracking branch 'azure/main' into wenhao/scg-cli
036a88c
Gateway cli
dc0c56f
Gateway cli
eb0ef11
update test
3a60fdb
Add preview for nacos
c6b0743
Merge remote-tracking branch 'azure/main' into wenhao/scg-cli
b5a96de
Add history
26cb728
Remove useless parameter
813a1ca
Remove unused import
218c10e
revert recording test
28bcc64
update tests
6d6e81e
Add recording
5dac9c2
remove class
2e47e63
Merge remote-tracking branch 'azure/main' into wenhao/scg-cli-local
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Gateway cli
- Loading branch information
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -225,7 +225,7 @@ def load_command_table(self, args): | |
g.custom_show_command('show', 'show_admin_for_spring') | ||
g.custom_command('delete', 'delete_admin_for_spring', confirmation=True, supports_no_wait=True) | ||
|
||
with self.command_group('containerapp env java-component gateway-for-spring') as g: | ||
with self.command_group('containerapp env java-component gateway-for-spring', is_preview=True) as g: | ||
g.custom_command('create', 'create_gateway_for_spring', supports_no_wait=True) | ||
g.custom_command('update', 'update_gateway_for_spring', supports_no_wait=True) | ||
g.custom_show_command('show', 'show_gateway_for_spring') | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. what about list? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The list command is consistent with other Java components at the Java component level. |
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried https://aka.ms/gateway-for-spring-routes-yaml
But seems it doesn't work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The link will point to our SCG doc, we will release the doc after the cli released, and make the link available.