Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{CI} Update pipeline to use Python 3.12 #8116

Merged
merged 2 commits into from
Oct 25, 2024
Merged

{CI} Update pipeline to use Python 3.12 #8116

merged 2 commits into from
Oct 25, 2024

Conversation

bebound
Copy link
Contributor

@bebound bebound commented Oct 9, 2024

Use 3.12 in CI as Azure/azure-cli#29887 is merged

Copy link

azure-client-tools-bot-prd bot commented Oct 9, 2024

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

Copy link

Hi @bebound,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@bebound bebound mentioned this pull request Oct 9, 2024
4 tasks
@yonzhan
Copy link
Collaborator

yonzhan commented Oct 9, 2024

CI

Copy link

github-actions bot commented Oct 9, 2024

- bash: |
#!/usr/bin/env bash
set -ev
pip install wheel==0.30.0 requests packaging
pip install wheel==0.30.0 requests packaging setuptools
Copy link
Contributor Author

@bebound bebound Oct 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wheel 0.30.0 is not compatible with Python 3.12 as distutils was removed. Install setuptools as a workaround.

Traceback (most recent call last):
  File "/mnt/vss/_work/1/s/./scripts/ci/test_index.py", line 23, in <module>
    from wheel.install import WHEEL_INFO_RE
  File "/opt/hostedtoolcache/Python/3.12.6/x64/lib/python3.12/site-packages/wheel/install.py", line 17, in <module>
    from .paths import get_install_paths
  File "/opt/hostedtoolcache/Python/3.12.6/x64/lib/python3.12/site-packages/wheel/paths.py", line 7, in <module>
    import distutils.command.install as install
ModuleNotFoundError: No module named 'distutils'

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why installing setuptools can work around it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

setuptools provides a "vendored" distutils.

root@7a5d336f2f35:/# python -c "import distutils;print(distutils.__path__)"
['/usr/local/lib/python3.12/site-packages/setuptools/_distutils']

@bebound bebound merged commit 9ec9484 into Azure:main Oct 25, 2024
20 checks passed
@bebound bebound deleted the 3.12-ci branch October 25, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Assign Auto assign by bot CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants