-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Draft - Do not merge] [Quantum] Use Post Storage URI and SAS token like Quantum Python SDK (27643) #8242
Draft
warren-jones
wants to merge
28
commits into
Azure:main
Choose a base branch
from
warren-jones:27643-use-post-storage-uri-and-sas
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
[Draft - Do not merge] [Quantum] Use Post Storage URI and SAS token like Quantum Python SDK (27643) #8242
warren-jones
wants to merge
28
commits into
Azure:main
from
warren-jones:27643-use-post-storage-uri-and-sas
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️Azure CLI Extensions Breaking Change Test
|
azure-client-tools-bot-prd
bot
added this to the November 2024 (2024-11-19)❗ Breaking change release ❗ milestone
Nov 6, 2024
Hi @warren-jones, |
Thank you for your contribution! We will review the pull request and get back to you soon. |
microsoft-github-policy-service
bot
requested review from
kairu-ms,
necusjz,
yonzhan and
wangzelin007
November 6, 2024 02:06
Release SuggestionsModule: quantum
Notes
|
…ntialUnavailableError messages
…moved '.dev3' from the version number
warren-jones
changed the title
[Draft - Do not merge] [Quantum] Use Post Storage URI and SAS token like Quantum Python SDK
[Draft - Do not merge] [Quantum] Use Post Storage URI and SAS token like Quantum Python SDK (27643)
Dec 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Azure Quantum CLI should use a Post Storage URI and a SAS token like Python SDK, azure-quantum-python.
Our CLI extension has a potential issue with directly using a user's credentials to access the storage account to upload input or download output files, when our other SDK uses the PostStorageUri endpoint in our service. If we had the CLI extension use the same method, we won't run into user permission issues with using CLI (if they have access to workspace, but not to storage account).
Files that comprise the azure-identity, azure-storage-blob, azure-quantum PyPI packages were copied into vendored_sdks to eliminate dependency on those external packages. This is in keeping with the recent requirement imposed by the Azure CLI team, which resulted in an earlier PR: [Quantum] Ship peer dependencies in vendored sdks folder (25369) by warren-jones · Pull Request #8041 · Azure/azure-cli-extensions
The first two groups of files were copied without modification from the “Azure SDK for Python” repository:
However, only the files needed for input data upload were copied from the azure-quantum-python repo into vendored_sdks. Many of these files require manual edits to lines which import methods from external packages:
To minimize the number of edited lines, portions of azure-quantum-python were not copied. They can be added as needed for future CLI requirements.
Prior to this PR, a modified storage.py file from azure-quantum-python was incorporated into the CLI extension as azure-cli-extensions\src\quantum\azext_quantum_storage.py, but that file required a significant number of cosmetic edits to pass the Azure CLI CI/CD style checks. Including it in vendored_sdks exempts it from those style restrictions, which will simplify maintenance updates.
Related commands
az quantum job submit
az quantum execute
az run
azdev style <YOUR_EXT>
locally? (pip install azdev
required)python scripts/ci/test_index.py -q
locally? (pip install wheel==0.30.0
required)