Add git hooks support #8251
Add git hooks support #8251
Conversation
️✔️Azure CLI Extensions Breaking Change Test
|
azure-client-tools-bot-prd
bot
added this to the November 2024 (2024-11-19)❗ Breaking change release ❗ milestone
|
Hi @kairu-ms, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
kairu-ms
requested review from
necusjz,
evelyn-ys,
zhoxing-ms and
wangzelin007
| @@ -0,0 +1,13 @@ | |||
| #!/usr/bin/env sh | |||
| ":" //; if command -v pwsh >/dev/null 2>&1; then pwsh -ExecutionPolicy Bypass -File .githooks/pre-commit.ps1; else sh .githooks/pre-commit.sh; fi; exit $? # Try PowerShell Core first, then sh on Unix | |||
There was a problem hiding this comment.
The script assumes that the commit operation is executed from the repository's root directory. It uses relative paths like .githooks/xxx and .githooks\xxx to locate the hook scripts. If the commit command is run from a subdirectory, these paths will not resolve correctly, leading to errors because the scripts cannot be found.
There was a problem hiding this comment.
Actually it can work in the subdirectory
|
Could you confirm if these scripts have been tested on macOS to ensure they work correctly? |
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
Co-authored-by: ZelinWang <zelinwang@microsoft.com>
Co-authored-by: ZelinWang <zelinwang@microsoft.com>
Co-authored-by: ZelinWang <zelinwang@microsoft.com>
Co-authored-by: ZelinWang <zelinwang@microsoft.com>
kairu-ms
force-pushed
the
feature-githooks
branch
from
246dfdc to
7b454d1
Compare
kairu-ms
force-pushed
the
feature-githooks
branch
from
7b454d1 to
a0fec21
Compare
kairu-ms
force-pushed
the
feature-githooks
branch
from
2e90126 to
d72ca11
Compare
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
Add pre-commit with secret detected.
Add pre-push with style, linter, and tests check.
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.