Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[containerapp] Add new options for labels mode #8324

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

Tratcher
Copy link

This adds support for the new containerapp activeRevisionMode 'labels' mode and the associated target-label option. These are used when creating or updating applications. There are also new commands to show the history of label revision assignments.

All commands except label-history already exist and need to be overridden by the extension to support these new features.

Needs tests.


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

  • 'az containerapp create': New target-label option for Labels revision mode.
  • 'az containerapp update': New revisions-mode and target-label options for Labels revision mode.
  • 'az containerapp up': New revisions-mode and target-label options for Labels revision mode.
  • 'az containerapp label-history': New list and show commands to see label revision assignment history.
  • 'az containerapp revision set-mode': New target-label option for Labels revision mode.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

Copy link

azure-client-tools-bot-prd bot commented Nov 26, 2024

⚠️Azure CLI Extensions Breaking Change Test
⚠️containerapp
rule cmd_name rule_message suggest_message
⚠️ 1006 - ParaAdd containerapp create cmd containerapp create added parameter target_label
⚠️ 1010 - ParaPropUpdate containerapp create cmd containerapp create update parameter revisions_mode: updated property choices from ['multiple', 'single'] to ['labels', 'multiple', 'single']
⚠️ 1011 - SubgroupAdd containerapp label-history sub group containerapp label-history added
⚠️ 1006 - ParaAdd containerapp revision set-mode cmd containerapp revision set-mode added parameter target_label
⚠️ 1010 - ParaPropUpdate containerapp revision set-mode cmd containerapp revision set-mode update parameter mode: updated property choices from ['multiple', 'single'] to ['labels', 'multiple', 'single']
⚠️ 1006 - ParaAdd containerapp up cmd containerapp up added parameter revisions_mode
⚠️ 1006 - ParaAdd containerapp up cmd containerapp up added parameter target_label
⚠️ 1006 - ParaAdd containerapp update cmd containerapp update added parameter revisions_mode
⚠️ 1006 - ParaAdd containerapp update cmd containerapp update added parameter target_label

Copy link

Hi @Tratcher,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

Copy link

Hi @Tratcher,
Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

@yonzhan
Copy link
Collaborator

yonzhan commented Nov 26, 2024

Thank you for your contribution! We will review the pull request and get back to you soon.

Copy link

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

Copy link

Hi @Tratcher

Release Suggestions

Module: containerapp

  • Update VERSION to 1.1.0b2 in src/containerapp/setup.py

Notes

@Tratcher Tratcher marked this pull request as ready for review November 28, 2024 00:05
@yanzhudd
Copy link
Contributor

Hi @Greedygre
please review this PR as well, thanks

@Greedygre
Copy link
Contributor

please make sure all checks in CI passed.

If the PR is to add new feature support, please get approval from your team who could be responsible for your business logic.

@zhoxing-ms
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@yanzhudd yanzhudd closed this Dec 9, 2024
@yanzhudd yanzhudd reopened this Dec 9, 2024
Copy link

github-actions bot commented Dec 9, 2024

🚫All pull requests will be blocked to merge until Jan 6, 2025 due to CCOA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants