-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[containerapp] Add new options for labels mode #8324
base: main
Are you sure you want to change the base?
Conversation
|
rule | cmd_name | rule_message | suggest_message |
---|---|---|---|
containerapp create | cmd containerapp create added parameter target_label |
||
containerapp create | cmd containerapp create update parameter revisions_mode : updated property choices from ['multiple', 'single'] to ['labels', 'multiple', 'single'] |
||
containerapp label-history | sub group containerapp label-history added |
||
containerapp revision set-mode | cmd containerapp revision set-mode added parameter target_label |
||
containerapp revision set-mode | cmd containerapp revision set-mode update parameter mode : updated property choices from ['multiple', 'single'] to ['labels', 'multiple', 'single'] |
||
containerapp up | cmd containerapp up added parameter revisions_mode |
||
containerapp up | cmd containerapp up added parameter target_label |
||
containerapp update | cmd containerapp update added parameter revisions_mode |
||
containerapp update | cmd containerapp update added parameter target_label |
Hi @Tratcher, |
Hi @Tratcher, |
Thank you for your contribution! We will review the pull request and get back to you soon. |
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
Hi @Tratcher Release SuggestionsModule: containerapp
Notes
|
Hi @Greedygre |
please make sure all checks in CI passed. If the PR is to add new feature support, please get approval from your team who could be responsible for your business logic. |
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
🚫All pull requests will be blocked to merge until Jan 6, 2025 due to CCOA |
This adds support for the new containerapp activeRevisionMode 'labels' mode and the associated target-label option. These are used when creating or updating applications. There are also new commands to show the history of label revision assignments.
All commands except label-history already exist and need to be overridden by the extension to support these new features.
Needs tests.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>
locally? (pip install azdev
required)python scripts/ci/test_index.py -q
locally? (pip install wheel==0.30.0
required)