AKS-Preview CLI extension default to SLB+VMSS #906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR: |
added 23 commits
August 16, 2019 18:46
added 2 commits
August 26, 2019 20:04
|
@zikalino @zqingqing1 Can you take a look? |
zikalino
reviewed
Aug 27, 2019
zikalino
approved these changes
Aug 27, 2019
zqingqing1
suggested changes
Aug 27, 2019
|
Would it be possible to know why the --enable-vmss flag has been removed from this PR? |
ManuInNZ
pushed a commit
to ManuInNZ/azure-cli-extensions
that referenced
this pull request
Apr 11, 2020
* Vendor in 2019_08_01 SDK * CLI extension for SLB/VMSS * Update index * Update index.json * Fix style check error * Fix style check * Fix check style * Fix check style * Fix checkstyle * Fix check style * Fix check style * Remove unused import * Upgrade pylint to address distutils.versions importing issue * Disable lint error * Update index.json * Fix codestyle * Fix load command issue * Update index * Rename agent-pool-availability-type to vm-set-type * Update helper message * Update index.json * Update helper doc * Update index.json * Bump version to 0.4.11 * Update index.json * Update helper doc * Update index.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions: