az command returns 0 when failing

[fuhuifang]

Related command
az extension show -n azure-ml-cli

Describe the bug
When azure-ml-cli is not installed, we expect an error with exitcode 1. This works properly for 2.39 and older, but with 2.40, it returns 0.

To Reproduce
Run the following python script:

import subprocess
subprocess.run(args=['pwsh', '-EncodedCommand', 'YQB6ACAAZQB4AHQAZQBuAHMAaQBvAG4AIABzAGgAbwB3ACAALQBuACAAYQB6AHUAcgBlAC0AYwBsAGkALQBtAGwA'])

Outputs
2.40

2.39

Expected behavior
CompletedProcess(args=['pwsh', '-EncodedCommand', 'YQB6ACAAZQB4AHQAZQBuAHMAaQBvAG4AIABzAGgAbwB3ACAALQBuACAAYQB6AHUAcgBlAC0AYwBsAGkALQBtAGwA'], returncode=1)

Environment summary
Windows, python 3.8

Additional context
Similar to #23808

[ghost]

Thank you for your feedback. This has been routed to the support team for assistance.

[yonzhan]

route to CXP team

[yjm607]

Hi Yong, will there be an IcM ticket filed for this issue? It is affecting all customers of the Substrate Intelligence AI platform and the Shrike library.

[jiasli]

This looks like some issue with PowerShell.

Say we have the same test.cmd and test.ps1:

test.ps1:

python -c "exit(1)"

test.cmd:

@echo off
python -c "exit(1)"

The exit code is correct when they are invoked directly:

PS D:\> ./test.cmd ; echo $LASTEXITCODE
1
PS D:\> ./test.ps1 ; echo $LASTEXITCODE
1

However, when invoked by pwsh.exe, they return different result:

PS D:\> pwsh -Command "./test.cmd" ; echo $LASTEXITCODE
1
PS D:\> pwsh -Command "./test.ps1" ; echo $LASTEXITCODE
0

If test.ps1 contains

Exit 1

It works as expected:

PS D:\> ./test.ps1 ; echo $LASTEXITCODE
1
PS D:\> pwsh -Command "./test.ps1" ; echo $LASTEXITCODE
1

Azure CLI switched to az.ps1 in #23514, leading to this problem.

[jiasli]

On contrary, cmd.exe works as expected:

D:\>test.cmd & echo %ErrorLevel%
1
D:\>cmd.exe /c "test.cmd" & echo %ErrorLevel%
1

So does Bash:

user2@DESKTOP-A79F1:~$ ./test.sh ; echo $?
1
user2@DESKTOP-A79F1:~$ bash -c "./test.sh" ; echo $?
1

[jiasli]

We will revert the change in #24015

[saisankargochhayat]

Also facing the same issue, looking forward to the next release fixing this issue!

[yonzhan]

https://github.com/Azure/azure-cli/milestone/122 Build to Cloud Shell: 10/10/2022 Official Release: 10/12/2022