Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Revert #23514: Rename entry script az.ps1 to azps.ps1 #24015

Merged
merged 1 commit into from
Sep 30, 2022

Conversation

jiasli
Copy link
Member

@jiasli jiasli commented Sep 27, 2022

Description
#23514 added az.ps1 so that when Azure CLI is invoked in PowerShell, az.ps1 is called instead of az.cmd.

However, this change introduced 5 new issues:

Arguments

stdin

Exit code

Shell interaction

This PR reverts the change by renaming az.ps1 to azps.ps1 so that users can still use the .ps1 entry script if they want, but by default, when calling az, az.cmd will be called as before.

We will work with PowerShell team to see how to fix these issues.

@ghost ghost added Auto-Assign Auto assign by bot Core CLI core infrastructure labels Sep 27, 2022
@ghost ghost requested a review from yonzhan September 27, 2022 03:01
@ghost ghost assigned jiasli Sep 27, 2022
@ghost ghost added this to the Sep 2022 (2022-10-12) - For Ignite milestone Sep 27, 2022
@yonzhan
Copy link
Collaborator

yonzhan commented Sep 27, 2022

Users are able to use azpwsh.ps1 on demand.

@yonzhan yonzhan requested a review from jsntcy September 27, 2022 03:08
Copy link
Contributor

@chasewilson chasewilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a problem with leaving it az.ps1? Is the customer able to specify their entry script by the extension?

@jiasli
Copy link
Member Author

jiasli commented Sep 28, 2022

Is there a problem with leaving it az.ps1?

Yes. If we don't rename az.ps1, it will be the default script when az is called from PowerShell, overriding az.cmd.

Is the customer able to specify their entry script by the extension?

They can.

@jiasli jiasli changed the title [Core] Rename entry script az.ps1 to azpwsh.ps1 [Core] Revert #23514: Rename entry script az.ps1 to azpwsh.ps1 Sep 30, 2022
@jiasli jiasli changed the title [Core] Revert #23514: Rename entry script az.ps1 to azpwsh.ps1 [Core] Revert #23514: Rename entry script az.ps1 to azps.ps1 Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Assign Auto assign by bot Core CLI core infrastructure Shell - PowerShell
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants