-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Core] Revert #23514: Rename entry script az.ps1
to azps.ps1
#24015
Conversation
Users are able to use azpwsh.ps1 on demand. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a problem with leaving it az.ps1
? Is the customer able to specify their entry script by the extension?
Yes. If we don't rename
They can. |
az.ps1
to azpwsh.ps1
az.ps1
to azpwsh.ps1
az.ps1
to azpwsh.ps1
az.ps1
to azps.ps1
Description
#23514 added
az.ps1
so that when Azure CLI is invoked in PowerShell,az.ps1
is called instead ofaz.cmd
.However, this change introduced 5 new issues:
Arguments
$mylist
to Azure CLI #23797: PowerShell array$mylist
is splatted when calling.cmd
, but not when calling.ps1
. Instead, the array is concatenated as a single string.--
stops working in PowerShell since 2.40.0 #24034: PowerShell doesn't include--
in$args
--%
stops working since Azure CLI 2.40.0 #24114:--%
only works for native executable, but not.ps1
script.stdin
.ps1
, PowerShell doesn't automatically connectstdin
to pipeline.Exit code
pwsh.exe
calling.ps1
calling.exe
Shell interaction
az
can't be invoked byStart-Process
since 2.40.0 #24005:.cmd
can be invoked byStart-Process
, but.ps1
cannot.This PR reverts the change by renaming
az.ps1
toazps.ps1
so that users can still use the.ps1
entry script if they want, but by default, when callingaz
,az.cmd
will be called as before.We will work with PowerShell team to see how to fix these issues.