Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes curl install with space in custom install path #1186

Merged
merged 1 commit into from
Oct 28, 2016

Conversation

derekbekoe
Copy link
Member

@derekbekoe derekbekoe commented Oct 28, 2016

Instead of using command.split(), pass in the command to execute as a list always

See #1070

virtualenv and pip don't work well with spaces in paths though so installs with spaces will still fail until that's addressed:
pypa/virtualenv#53
pypa/pip#923

Copy link
Member

@tjprescott tjprescott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could also look into the shlex module, which will let you split but preserve spaces in quoted strings.

@derekbekoe
Copy link
Member Author

@tjprescott I tried it but it behaved in the same way:

import shlex
dir = '/users/myname/Documents/Virtual Machines/share/software/azure'
txt = '{0} virtualenv.py --python {0} {1}'.format('/usr/bin/python', dir)
shlex.split(txt)
txt.split()

@derekbekoe derekbekoe merged commit 98f1543 into Azure:master Oct 28, 2016
@derekbekoe derekbekoe deleted the fix-install-split branch October 28, 2016 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants