[acr] support anonymous pull #17006
Merged
[acr] support anonymous pull #17006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
acr |
yungezz
reviewed
Feb 20, 2021
| @@ -94,6 +94,9 @@ def load_arguments(self, _): # pylint: disable=too-many-statements | |||
| with self.argument_context('acr update', arg_group='Network Rule') as c: | |||
| c.argument('data_endpoint_enabled', get_three_state_flag(), help="Enable dedicated data endpoint for client firewall configuration") | |||
|
|
|||
| with self.argument_context('acr update') as c: | |||
| c.argument('anonymous_pull_enabled', get_three_state_flag(), help="Enables registry-wide pull from unauthenticated clients") | |||
There was a problem hiding this comment.
just curious, should it be enable_anonymous_call?
| @@ -94,6 +94,9 @@ def load_arguments(self, _): # pylint: disable=too-many-statements | |||
| with self.argument_context('acr update', arg_group='Network Rule') as c: | |||
| c.argument('data_endpoint_enabled', get_three_state_flag(), help="Enable dedicated data endpoint for client firewall configuration") | |||
|
|
|||
| with self.argument_context('acr update') as c: | |||
| c.argument('anonymous_pull_enabled', get_three_state_flag(), help="Enables registry-wide pull from unauthenticated clients") | |||
There was a problem hiding this comment.
Suggested change
| c.argument('anonymous_pull_enabled', get_three_state_flag(), help="Enables registry-wide pull from unauthenticated clients") | |
| c.argument('anonymous_pull_enabled', get_three_state_flag(), help="Enable registry-wide pull from unauthenticated clients") |
yungezz
approved these changes
Feb 23, 2021
yungezz
reviewed
Mar 9, 2021
| @@ -29,7 +29,7 @@ azure-mgmt-cognitiveservices==6.3.0 | |||
| azure-mgmt-compute==19.0.0 | |||
| azure-mgmt-consumption==2.0.0 | |||
| azure-mgmt-containerinstance==1.5.0 | |||
| azure-mgmt-containerregistry==3.0.0rc16 | |||
| azure-mgmt-containerregistry==3.0.0rc17 | |||
There was a problem hiding this comment.
since SDK version changed, I'll suppose you've already run live tests :)
There was a problem hiding this comment.
@yungezz there is no api version bump in this SDK version. The spec change PR is here FYI: Azure/azure-rest-api-specs#13001
But I still ran a few more tests live to provide enough confidence for this PR. Please take a look and let me know if you have any other suggestions.
yungezz
approved these changes
Mar 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Label "Do Not Merge" as this is pending SDK releaseedit: azure-mgmt-containerregistry 3.0.0rc17 was released
Description
Support registry-wide pull from unauthenticated clients
Testing Guide
az acr update -n myRegistry --anonymous-pull-enabled
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.