{Compute} Update description of license_msg #17427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would suggest update help in command level instead of parameter level |
yungezz
reviewed
Mar 24, 2021
| @@ -833,6 +833,8 @@ def load_arguments(self, _): | |||
| license_msg = "Specifies that the Windows image or disk was licensed on-premises. " \ | |||
| "To enable Azure Hybrid Benefit for Windows Server, use 'Windows_Server'. " \ | |||
| "To enable Multitenant Hosting Rights for Windows 10, use 'Windows_Client'. " \ | |||
| "Remember that after setting the license type on VMSs, execute the following command to apply the changes to the existing VM." \ | |||
There was a problem hiding this comment.
Suggested change
| "Remember that after setting the license type on VMSs, execute the following command to apply the changes to the existing VM." \ | |
| "Remember that after setting the license type on VMSS, execute the following command to apply the changes to the existing VM." \ |
qwordy
reviewed
Apr 2, 2021
| @@ -2758,6 +2758,7 @@ | |||
| helps['vmss update'] = """ | |||
| type: command | |||
| short-summary: Update a VMSS. | |||
| long-summary: To update a global scale set property, you must update the property in the scale set model.Remember to execute the `az vmss update-instances -g 'Your resource group name' -n 'Your VMSS name' --instance-ids '*' ` command after using this command to make the change take effect. If you don't set the automatic modes for the upgrade policy. | |||
There was a problem hiding this comment.
@BigCat20196 Put it in short summary. Long summary is not shown in references.
There was a problem hiding this comment.
OK，I've tried to write it in the short summary.
qwordy
reviewed
Apr 2, 2021
| @@ -2757,8 +2757,7 @@ | |||
|
|
|||
| helps['vmss update'] = """ | |||
| type: command | |||
| short-summary: Update a VMSS. | |||
| long-summary: To update a global scale set property, you must update the property in the scale set model.Remember to execute the `az vmss update-instances -g 'Your resource group name' -n 'Your VMSS name' --instance-ids '*' ` command after using this command to make the change take effect. If you don't set the automatic modes for the upgrade policy. | |||
| short-summary: Update a VMSS.After that,remember to execute the 'az vmss update-instances' command to make the changes take effect, assuming that you have not set the automatic modes for the upgrade policy | |||
There was a problem hiding this comment.
Suggested change
| short-summary: Update a VMSS.After that,remember to execute the 'az vmss update-instances' command to make the changes take effect, assuming that you have not set the automatic modes for the upgrade policy | |
| short-summary: Update a VMSS. Run 'az vmss update-instances' command to roll out the changes to VMs if you have not configured upgrade policy. |
qwordy
reviewed
Apr 2, 2021
qwordy
changed the title
Co-authored-by: Feiyue Yu <iamyfy@163.com>
|
@BigCat20196 You should have seen a "Commit suggestion" button on my comment. If it looks good, just click it. |
qwordy
approved these changes
Apr 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolve #16541
[Compute] Modify description of license_ msg. After reminding the user to set the license type on VMSS, execute the following command to apply the change to the existing VM.
az vmss update-instances -g "Your resource group name" -n "Your VMSS name" --instance-ids "*"Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.