-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Compute] vm create --count mode, support vnet and subnet configuration #17660
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you link your PR which supports the --count
parameter here? I have no context why we need remove the lines in the validation function.
@@ -1781,9 +1782,7 @@ def _validate_count(namespace): | |||
namespace.public_ip_address_dns_name, | |||
namespace.storage_account, | |||
namespace.storage_container_name, | |||
namespace.subnet, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why we remove it here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because I disabled it. Now I decide to enable it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the change itself LGTM, is there any test on --count, to expand coverage of those params? |
I should double all vm test with only one difference "--count". I give up. |
At least |
Description
Resolve #17649
Support --vnet-name, --subnet
Example (3) can work in current version of Azure CLI. Example (1) (2) will work on 5/4/2021. We need to be aware of "az vm create" does not support full functionality of vnet and subnet creation. Use "az network vnet" to create vnet and subnet if you'd like to control all configuration.
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.