Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{Packaging} Include *.ipynb file when packaging #17704

Merged
merged 3 commits into from
Apr 19, 2021

Conversation

evelyn-ys
Copy link
Member

Description

Synapse's test: test_notebook fails in L1164 in CI Full Test

def test_notebook(self):
self.kwargs.update({
'workspace': 'testsynapseworkspace',
'name': 'notebook',
'spark-pool': 'testpool',
'file': os.path.join(os.path.join(os.path.dirname(__file__), 'assets'), 'notebook.ipynb')
})
# create notebook
self.cmd(
'az synapse notebook create --workspace-name {workspace} --name {name} --file @"{file}" '
'--spark-pool-name {spark-pool}',
checks=[
self.check('name', self.kwargs['name'])
])

The error msg shows:

InvalidArgumentValueError: Failed to parse JSON: @/usr/lib64/az/lib/python3.6/site-packages/azure/cli/command_modules/synapse/tests/latest/assets/notebook.ipynb

It might caused because .ipynb file was not packaged in full test. This PR aims to fix it.


This checklist is used to make sure that common guidelines for a pull request are followed.

@evelyn-ys evelyn-ys requested a review from jiasli as a code owner April 15, 2021 06:58
@evelyn-ys evelyn-ys self-assigned this Apr 15, 2021
@yonzhan
Copy link
Collaborator

yonzhan commented Apr 15, 2021

packaging

@yonzhan yonzhan added this to the S186 milestone Apr 15, 2021
@evelyn-ys evelyn-ys merged commit 79cffd3 into Azure:dev Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants