Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{Appservice} Update expire date for some parameters #18133

Merged
merged 1 commit into from
May 19, 2021

Conversation

qwordy
Copy link
Member

@qwordy qwordy commented May 19, 2021

Description

c.argument('force_dns_registration', help="If true, web app hostname is force registered with DNS",
                   arg_type=get_three_state_flag(return_label=True), deprecate_info=c.deprecate(expiration='2.24.0'))

It will break the release. I changed it to a lager version.

Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.


This checklist is used to make sure that common guidelines for a pull request are followed.

@qwordy qwordy requested a review from Juliehzl as a code owner May 19, 2021 03:51
@qwordy
Copy link
Member Author

qwordy commented May 19, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@yonzhan yonzhan added this to the S187 milestone May 19, 2021
@yonzhan yonzhan requested a review from zhoxing-ms May 19, 2021 04:41
@yonzhan
Copy link
Collaborator

yonzhan commented May 19, 2021

Appservice

@qwordy
Copy link
Member Author

qwordy commented May 19, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants