Add Python 3.6 to CI #1821
Merged
Add Python 3.6 to CI #1821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
troydai
reviewed
Jan 23, 2017
| # PyLint does not yet support Python 3.6 https://github.com/PyCQA/pylint/issues/1241 | ||
| if [ "$TRAVIS_PYTHON_VERSION" != "3.6" ]; then | ||
| check_style --ci; | ||
| fi |
- Do not run pylint on 3.6 as pylint doesn’t support 3.6 yet - Add Python 3.6 to package classifiers
derekbekoe
force-pushed
the
python-3-6
branch
from
1eb9937 to
ad3037b
Compare
|
@troydai can you take a look at the updated PR? |
|
@derekbekoe On it. |
troydai
approved these changes
Jan 24, 2017
| @@ -46,6 +46,10 @@ | |||
|
|
|||
| # MOCK METHODS | |||
|
|
|||
| # Workaround until https://github.com/kevin1024/vcrpy/issues/293 is fixed. | |||
| vcr_connection_request = vcr.stubs.VCRConnection.request | |||
| vcr.stubs.VCRConnection.request = lambda *args, **kwargs: vcr_connection_request(*args) | |||
There was a problem hiding this comment.
I'm pretty sure flake8 will bad mouth this line of code. But we disable the style check here anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1626