Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{testsdk} Add ConfigArgParse dependency #20688

Merged
merged 1 commit into from
Dec 10, 2021
Merged

Conversation

jiasli
Copy link
Member

@jiasli jiasli commented Dec 10, 2021

Description

Extension CI fails:

https://dev.azure.com/azure-sdk/public/_build/results?buildId=1240705&view=logs&j=59e8686e-5e74-514d-6cad-f7d66c66b425&t=59602323-6717-504d-f2cc-5c81369f935f&l=736

ERROR: azext_aks_preview.tests.latest.test_aks_commands (unittest.loader._FailedTest)
----------------------------------------------------------------------
ImportError: Failed to import test module: azext_aks_preview.tests.latest.test_aks_commands
Traceback (most recent call last):
  File "/opt/hostedtoolcache/Python/3.8.12/x64/lib/python3.8/unittest/loader.py", line 436, in _find_test_path
    module = self._get_module_from_name(name)
  File "/opt/hostedtoolcache/Python/3.8.12/x64/lib/python3.8/unittest/loader.py", line 377, in _get_module_from_name
    __import__(name)
  File "/home/vsts/work/1/s/src/aks-preview/azext_aks_preview/tests/latest/test_aks_commands.py", line 10, in <module>
    from azure.cli.testsdk import (
  File "/home/vsts/work/1/s/azure-cli/src/azure-cli-testsdk/azure/cli/testsdk/__init__.py", line 6, in <module>
    from .scenario_tests import live_only, record_only, get_sha1_hash
  File "/home/vsts/work/1/s/azure-cli/src/azure-cli-testsdk/azure/cli/testsdk/scenario_tests/__init__.py", line 13, in <module>
    from .base import IntegrationTestBase, ReplayableTest, LiveTest
  File "/home/vsts/work/1/s/azure-cli/src/azure-cli-testsdk/azure/cli/testsdk/scenario_tests/base.py", line 17, in <module>
    from .config import TestConfig
  File "/home/vsts/work/1/s/azure-cli/src/azure-cli-testsdk/azure/cli/testsdk/scenario_tests/config.py", line 6, in <module>
    import configargparse
ModuleNotFoundError: No module named 'configargparse'

This is because azure_devtools requires ConfigArgParse

https://github.com/Azure/azure-python-devtools/blob/aae33c216028960fbf54e70dcb1c579600034054/setup.py#L30

DEPENDENCIES = [
    'ConfigArgParse>=0.12.0',

but it is not added in

Main repo CI doesn't fail because ConfigArgParse is in

  • src/azure-cli/requirements.py3.Darwin.txt
  • src/azure-cli/requirements.py3.Linux.txt

added by #9785, but they are not in src/azure-cli/requirements.py3.windows.txt and it is not used by any code. I have no idea why they were introduced.

@jiasli jiasli merged commit de6b68e into Azure:dev Dec 10, 2021
@jiasli jiasli deleted the configargparse branch December 10, 2021 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants